Authenticate with cinder v3 endpoint by default #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v3 endpoint has been supported by the charms since Pike, and the V2 endpoint was removed in Xena, therefore it makes to use the v3 endpoint by default at this point.
lourot
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Makes sense, thanks! Waiting for https://review.opendev.org/c/openstack/charm-cinder/+/814177 to turn green
freyes
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
LGTM and https://review.opendev.org/c/openstack/charm-cinder/+/814177 completed successfully 👍
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Nov 22, 2021
In this patch we drop creation of the v2 volume endpoint for OpenStack Xena onward. Upstream cinder removed the block storage v2 API in commit e05b261a "Remove Block Storage API v2". func-test-pr: openstack-charmers/zaza-openstack-tests#670 Depends-On: https://review.opendev.org/c/openstack/charm-cinder/+/816007 Closes-Bug: #1947387 Change-Id: Ie553a53f794f2cdd262bf77364e6374244844b92
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 22, 2021
* Update charm-cinder from branch 'master'
to bc48c60f1cd0bf7ceb8813dced504f5e0d37d829
- Drop creation of v2 endpoint from OpenStack Xena+
In this patch we drop creation of the v2 volume endpoint for
OpenStack Xena onward. Upstream cinder removed the block storage
v2 API in commit e05b261a "Remove Block Storage API v2".
func-test-pr: openstack-charmers/zaza-openstack-tests#670
Depends-On: https://review.opendev.org/c/openstack/charm-cinder/+/816007
Closes-Bug: #1947387
Change-Id: Ie553a53f794f2cdd262bf77364e6374244844b92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v3 endpoint has been supported by the charms since Pike,
and the V2 endpoint was removed in Xena, therefore it makes
to use the v3 endpoint by default at this point.