Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designate-bind 'service_ips' config option tests. #685

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mkalcok
Copy link
Contributor

@mkalcok mkalcok commented Dec 14, 2021

LP issue: #1804057
Main charm PR: Opendev review
Specification: proposal

@mkalcok mkalcok marked this pull request as ready for review December 14, 2021 16:27
Copy link
Contributor

@gnuoy gnuoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the additional test

@gnuoy gnuoy merged commit 4b6fe3f into openstack-charmers:master Jun 21, 2022
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Jun 21, 2022
* Update charm-designate-bind from branch 'master'
  to 4000b6ea72e9ca2350a24af87a22afdef08556af
  - Add functionality to configure virtual service IPs
    
    Closes-Bug: #1804057
    func-test-pr: openstack-charmers/zaza-openstack-tests#685
    Change-Id: I29f2eeca508048fdf8464193368cce5720559b9e
openstack-mirroring pushed a commit to openstack/charm-designate-bind that referenced this pull request Jun 21, 2022
Closes-Bug: #1804057
func-test-pr: openstack-charmers/zaza-openstack-tests#685
Change-Id: I29f2eeca508048fdf8464193368cce5720559b9e
lolwww pushed a commit to lolwww/charm-designate-bind that referenced this pull request Mar 9, 2023
Closes-Bug: #1804057
func-test-pr: openstack-charmers/zaza-openstack-tests#685
Change-Id: I29f2eeca508048fdf8464193368cce5720559b9e
lolwww pushed a commit to lolwww/charm-designate-bind that referenced this pull request Mar 9, 2023
Closes-Bug: #1804057
func-test-pr: openstack-charmers/zaza-openstack-tests#685
Change-Id: I29f2eeca508048fdf8464193368cce5720559b9e
lolwww pushed a commit to lolwww/charm-designate-bind that referenced this pull request Mar 9, 2023
Closes-Bug: #1804057
func-test-pr: openstack-charmers/zaza-openstack-tests#685
Change-Id: I29f2eeca508048fdf8464193368cce5720559b9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants