Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for charm-openstack-dashboard #865

Merged

Conversation

esunar
Copy link

@esunar esunar commented Aug 31, 2022

Added tests for checking positive and negative matches for the Cache-Control and Pragma http headers.

If the requested resource is static ensure these headers are not set. Random static file used for testing.

Cache-Control: no-store
Pragma: no-cache

If the requested resource is dynamic ensure these headers are set. Login page used for testing.

Cache-Control: no-store
Pragma: no-cache

Closes-Bug: #1836518

Added tests for checking positive and negative matches for the
Cache-Control and Pragma http headers.

If the requested resource is static check if these headers are
not set
Cache-Control: no-store
Pragma: no-cache

If the resource is dynamic ensure these headers are set
Cache-Control: no-store
Pragma: no-cache
@gnuoy gnuoy merged commit c57ac56 into openstack-charmers:master Sep 5, 2022
openstack-mirroring pushed a commit to openstack/charm-openstack-dashboard that referenced this pull request Sep 5, 2022
Added or replaced Cache-Control and Pragma http headers with:
Cache-Control: no-store
Pragma: no-cache

func-test-pr: openstack-charmers/zaza-openstack-tests#865
Closes-Bug: #1836518
Change-Id: If437c5e41892e09adbaaa1add494c85671706622
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Sep 5, 2022
* Update charm-openstack-dashboard from branch 'master'
  to f888f4dbb2cb7108ed1d9bfc938f55d705aaf0d1
  - Merge "Disabled browser cache(excluding static files)"
  - Disabled browser cache(excluding static files)
    
    Added or replaced Cache-Control and Pragma http headers with:
    Cache-Control: no-store
    Pragma: no-cache
    
    func-test-pr: openstack-charmers/zaza-openstack-tests#865
    Closes-Bug: #1836518
    Change-Id: If437c5e41892e09adbaaa1add494c85671706622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants