Add functional tests for ceph-mon actions. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds functional validation for 2 actions of the ceph-mon charm that are currently being rewritten.
ChrisMacNaughton
approved these changes
Sep 9, 2022
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 9, 2022
* Update charm-ceph-mon from branch 'master'
to e60a23ae16bf8ef67b8917d3bae085ea4e9f99b9
- Rewrite actions/copy_pool into the oeprator framework
In addition to trivial changes (passing `event` into
the `copy_pool` function), this change introduces an
update to the actions/__init__.py that allows succinct
import and use from the main charm.py.
An apparently unrelated change is the removal of
charm-proof from the lint job, as it fails with the
removal of actions/copy-pool.
Change-Id: I66a5590ddf0f0bb5ca073a91b451f8c78598609a
func-test-pr: openstack-charmers/zaza-openstack-tests#866
openstack-mirroring
pushed a commit
to openstack/charm-ceph-mon
that referenced
this pull request
Sep 9, 2022
In addition to trivial changes (passing `event` into the `copy_pool` function), this change introduces an update to the actions/__init__.py that allows succinct import and use from the main charm.py. An apparently unrelated change is the removal of charm-proof from the lint job, as it fails with the removal of actions/copy-pool. Change-Id: I66a5590ddf0f0bb5ca073a91b451f8c78598609a func-test-pr: openstack-charmers/zaza-openstack-tests#866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functional validation for 2 actions of the ceph-mon charm that are currently being rewritten.
Tested here: https://review.opendev.org/c/openstack/charm-ceph-mon/+/854282