Add ceph osd tests #93
Conversation
n-pochet
force-pushed
the
feature/add-ceph-osd-tests
branch
2 times, most recently
from
fbd2e89
to
8652927
Compare
| @@ -151,3 +153,208 @@ def get_yaml_config(config_file): | |||
| # the pwd. | |||
| logging.info('Using config %s' % (config_file)) | |||
| return yaml.load(open(config_file, 'r').read()) | |||
|
|
|||
|
|
|||
| def get_process_id_list(unit_name, process_name, | |||
There was a problem hiding this comment.
Just a question: Have you seen
Line 670 in f8fdc65
zaza/zaza/charm_tests/test_utils.py
Line 168 in f8fdc65
There was a problem hiding this comment.
get_process_id_list will just output the list of PID(s) for a specific process.
But thanks for pointing me to that function. It will help me to simplify test_services.
zaza/charm_tests/ceph/tests.py
Outdated
|
|
||
| Verify the expected services are running on the service units. | ||
| """ | ||
| services = { |
There was a problem hiding this comment.
What you in effect are doing here is cinder and glance charm tests in the ceph charm test.
This is one of the Amuletisms we want to avoid in Zaza. What we could do instead is pull in relevant config or test snippets in the tests.yaml that in effect would validate that the other services are working as they should.
An example for the keystone charm which by pulling in a glance config function in effect validates that the glance services are running, that it successfully related itself to keystone etc etc:
https://review.openstack.org/#/c/589832/2/tests/tests.yaml
There was a problem hiding this comment.
Indeed. I will move that away.
I was indeed just copy/pasting the amulet tests.
Thanks!
n-pochet
force-pushed
the
feature/add-ceph-osd-tests
branch
27 times, most recently
from
4f1b8db
to
8bff8c3
Compare
n-pochet
force-pushed
the
feature/add-ceph-osd-tests
branch
3 times, most recently
from
3628bd1
to
8ac818f
Compare
zaza/charm_tests/ceph/tests.py
Outdated
| sleep_time = 30 | ||
| retry_count = 30 | ||
| file_mtime = None | ||
| time.sleep(sleep_time) |
There was a problem hiding this comment.
@n-pochet this should now be unnecessary. When you added the config_change contextmanager your test code will not be executed until after the config has been applied and all units are idle and thus the initial sleep is no longer needed. Please remove it.
zaza/charm_tests/ceph/tests.py
Outdated
| retry_sleep_time = 10 | ||
| with self.config_change(set_default, set_alternate): | ||
| with tempfile.TemporaryDirectory() as tempdir: | ||
| while tries <= retry_count and not file_mtime: |
There was a problem hiding this comment.
Is there any situation where ceph-osd unit will appear idle and ready before the crypt setup has finished after the config change? If not I believe the retry logic should be removed too.
Depends-On: openstack-charmers/zaza#93 Change-Id: I9a19960fdb239eb5a8d421f135285e89b8405267
n-pochet
force-pushed
the
feature/add-ceph-osd-tests
branch
from
b09e563
to
c5d6633
Compare
The goal is to create functional tests that matches the Amulet tests that are currently used for testing. * Add low-level ceph-osd test class to gather the ceph-osd's specific tests (processes, services, ...) * Add utilities that matches the ones in charm-helpers * Add unit tests
* Add functional test * Add helper functions * Add unit tests
Patch `zaza.utilities.generic.model.run_on_unit`
The name first_unit was removed and changed to lead_unit.
The output of the `ceph osd lspools` can be: * 1 glance,2rbd, or * 1 glance 2 rbd
If the unit is in `ready` state, it should also have configured everything correctly. There's therefore no need for a retry logic.
n-pochet
force-pushed
the
feature/add-ceph-osd-tests
branch
from
c5d6633
to
6f8bf5a
Compare
Depends-On: openstack-charmers/zaza#93 Change-Id: I9a19960fdb239eb5a8d421f135285e89b8405267
No origin for designate-bind series upgrade
The goal is to create functional tests that matches the Amulet tests
that are currently used for testing.
tests (processes, services, ...)