Move from goose to gophercloud #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alistarle Thank you very much for your work on this. I have created a feature base branch to work on this implementation, the branch can be found here [0] under the name "gophercloud" It has already covered some of the points you mentioned in the TODO list, including; use the os-client-config option and check that all the client really use the params from the clouds.yml
Also, please ignore any changes into the vendors dependencies, we can add those dependencies later via go mod. [0] https://github.com/openstack-exporter/openstack-exporter/tree/gophercloud |
niedbalski
added a commit
that referenced
this pull request
Sep 27, 2019
metrics to gophercloud. Fixes #27 Signed-off-by: Jorge Niedbalski <jnr@metaklass.org>
niedbalski
added a commit
that referenced
this pull request
Sep 30, 2019
This is a continuation pr of #27 for fixing #26 [ X] Use the --os-client-config args (currently, loading of the clouds.yml are done trough this function) [ X] Check that all the client really use the params from the clouds.yml (endpoint type, tls, etc...) [ X] Fix the tenant_id of the volume_status metrics (extended attribute of the volume API) [X ] Check that the refresh_client really works (make tests) [ X] Write/Fix the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the draft of my pull request to move from goose to gophercloud, a lot of work remain to do :