Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

Commit

Permalink
Propose new Code Review -1 text
Browse files Browse the repository at this point in the history
New Code Review -1 default text has been proposed on a ML thread.
Propose it here so that we can "review" it. If we can agree this should
be updated as in this change a Gerrit admin will have to update
All-Projects directly then this change can be merged.

Fixes-bug: 1258899
Change-Id: I145d393bba6d7ebede7fbcd1f592937a9daadaf9
  • Loading branch information
cboylan committed Aug 25, 2014
1 parent be43bbc commit 1c66994
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/source/gerrit.rst
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ Next, edit `project.config` to look like::
copyMinScore = true
function = MaxWithBlock
value = -2 Do not merge
value = -1 I would prefer that you didn't merge this
value = -1 This patch needs further work before it can be merged
value = 0 No score
value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me (core reviewer)
Expand Down

0 comments on commit 1c66994

Please sign in to comment.