Move -log sidecar container to dumb-init #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noticed in other operators, the -log sidecar ignores SIGTERM on delete. This patch moves the barbican-operator to the dumb-init usage to make sure the SIGTERM is handled properly by the sidecar. Fixes: OSPRH-3283 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
gibizer
approved these changes
Jan 16, 2024
vakwetu
approved these changes
Jan 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, gibizer, vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in other operators (and already fixed), the -log sidecar ignores
SIGTERMon delete.This patch moves the barbican-operator to the
dumb-initusage to make sure theSIGTERMis handled properly by the sidecar.Fixes: OSPRH-3283