Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-operator] Add option to set networkAttachments #1622

Merged

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented May 3, 2024

This will allow attaching secondary nics to the tempest pods and use that for the egress traffic to the respective network.
Without this all egress traffic flows through the default OCP cluster network and can trigger mtu specific
issues for non cluster n/w traffic as cluster n/w force lower MTU based on network backend used.

Default is empty list so no secondary interfaces will be attached by default.

Related-Issue: OSPRH-6546

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

This will allow attaching secondary nics to the tempest
pods and use that for the egress traffic to the respective
network.
Without this all egress traffic flows through the default
OCP cluster network and can trigger mtu specific
issues for non cluster n/w traffic as cluster n/w force
lower MTU based on network backend used.

Default is empty list so no secondary interfaces will
be attached by default.

Related-Issue: OSPRH-6546
karelyatin added a commit to karelyatin/nova-operator that referenced this pull request May 3, 2024
@karelyatin
Copy link
Contributor Author

karelyatin added a commit to karelyatin/nova-operator that referenced this pull request May 3, 2024
Requires to add networkAttachment to tempest pod so
it uses ctlplane network for egress traffic instead
of the default cluster network which has lower mtu
forced(100 less than primary interface for OVNKubernetes backend).

Depends-On: openstack-k8s-operators/ci-framework#1622
Related-Issue: OSPRH-6546
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjeanner
Copy link
Collaborator

cjeanner commented May 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 82ee463 into openstack-k8s-operators:main May 6, 2024
10 of 12 checks passed
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/nova-operator that referenced this pull request May 6, 2024
Requires to add networkAttachment to tempest pod so
it uses ctlplane network for egress traffic instead
of the default cluster network which has lower mtu
forced(100 less than primary interface for OVNKubernetes backend).

Depends-On: openstack-k8s-operators/ci-framework#1622
Related-Issue: OSPRH-6546
@lewisdenny lewisdenny removed their request for review May 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants