Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shiftstack] Templates for rendering the right values to be used in the DT #1729

Merged
merged 1 commit into from
May 31, 2024
Merged

[shiftstack] Templates for rendering the right values to be used in the DT #1729

merged 1 commit into from
May 31, 2024

Conversation

psathyan
Copy link
Contributor

@psathyan psathyan commented May 18, 2024 •
edited

Adding the templates required for rendering the config map that will be used for deploying OpenStack Services.

edpm-nodeset-values

  • key difference from common is the support for external network's fixed IP address incase of Ceph nodes.

network-values

  • key difference from common is the support for Octavia bridge

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

logs
https://review.rdoproject.org/zuul/buildset/771618eb32c94bb99b1b0b11025389d9

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@psathyan psathyan force-pushed the osasinfra03 branch 4 times, most recently from 9bbd428 to 70295e0 Compare May 24, 2024 07:13
@psathyan psathyan force-pushed the osasinfra03 branch 2 times, most recently from 3a7490a to c42dab3 Compare May 27, 2024 10:39
@rlobillo
Copy link
Contributor

Is this change strictly related to titan03? I think it is not right? Can we put this patch on review and reduce the dependencies?

@psathyan psathyan force-pushed the osasinfra03 branch 3 times, most recently from 9fb6217 to bf9c65f Compare May 28, 2024 05:02
@psathyan psathyan mentioned this pull request May 28, 2024
Draft
@psathyan psathyan force-pushed the osasinfra03 branch 2 times, most recently from fded803 to f36a13f Compare May 28, 2024 09:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/374de50b306048fea22763006baaf4df

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 16s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 20m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 12m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 23s
❌ cifmw-pod-k8s-snippets-source FAILURE in 5m 05s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 26s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 07s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 36s

@psathyan psathyan changed the title [shiftonstack03] Templates for rendering the right values to be used in the DT [shiftstack] Templates for rendering the right values to be used in the DT May 29, 2024
@psathyan psathyan marked this pull request as ready for review May 29, 2024 06:13
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/60ba8171988b4022a5dc4e7586091ffd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 19s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
❌ cifmw-pod-k8s-snippets-source FAILURE in 5m 00s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 56s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 59s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 33s

lpiwowar added a commit to openstack-k8s-operators/test-operator that referenced this pull request May 29, 2024
@lpiwowar
Testing Depends-On
613a445 
Depends-On: openstack-k8s-operators/ci-framework#1729
@lpiwowar lpiwowar mentioned this pull request May 29, 2024
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d4d907ad746447aab2cdef0a13922c64

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 32s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 12m 54s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 5m 45s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 58s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 09s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 53s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 51s

@psathyan
[shiftonstack03] Templates for deployed topologies
565e9e5 
Adding the templates required for rendering the config map that
will be used for deploying OpenStack Services.

*edpm-nodeset-values*
- key difference from common is the support for external network's
fixed IP address incase of Ceph nodes.

*network-values*
- key difference from common is the support for Octavia bridge

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
@pablintino
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81c904d into openstack-k8s-operators:main May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pablintino pablintino

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
3 participants
@psathyan @rlobillo @pablintino