Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pre-commit checks for cinder-operator #121

Conversation

amolkahat
Copy link
Contributor

This patch adds pre-commit checks to cinder
operator. It also adds .pre-commit-config.yaml
file.

Signed-off-by: Amol Kahat amolkahat@gmail.com

This patch adds pre-commit checks to cinder
operator. It also adds .pre-commit-config.yaml
file.

Signed-off-by: Amol Kahat <amolkahat@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

Hi @amolkahat. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amolkahat, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89e986d into openstack-k8s-operators:master Jan 31, 2023
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants