Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize checking bundle as well for leftovers #200

Closed

Conversation

yazug
Copy link
Contributor

@yazug yazug commented May 5, 2023

witch to checking make bundle instead of just manifests since make bundle calls manifests as well

witch to checking make bundle instead of just manifests
since make bundle calls manifests as well
@openshift-ci openshift-ci bot requested review from dprince and viroel May 5, 2023 17:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yazug
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

Hi @yazug. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Akrog
Copy link
Contributor

Akrog commented May 25, 2023

/ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@yazug: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check a3eb27f link true /test precommit-check
ci/prow/cinder-operator-build-deploy-kuttl a3eb27f link false /test cinder-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yazug yazug closed this Jun 21, 2023
@yazug yazug deleted the standardize_check_bundle branch June 21, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants