Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for DB writes only on reads (causality checks) #393

Merged

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented May 29, 2024

On PR 392 we changed to waiting on writes for updates and inserts, but upon further analysis we have decided that just doing it for reads should be enough, as the order of the updates will be reconciled automatically by the DB engine.

In this patch we change the value of mysql_wsrep_sync_wait to 1 to only wait on reads.

On PR 392 we changed to waiting on writes for updates and inserts, but
upon further analysis we have decided that just doing it for reads
should be enough, as the order of the updates will be reconciled
automatically by the DB engine.

In this patch we change the value of `mysql_wsrep_sync_wait` to 1 to
only wait on reads.
Copy link
Contributor

@zzzeek zzzeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just try it. if we still have errors, we can try adding bits though i dont think that would be the issue even then, we want to see that errors go away with the "1" setting

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 29, 2024

@Akrog: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cinder-operator-build-deploy-tempest b074794 link false /test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4afc791 into openstack-k8s-operators:main May 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants