Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set APITimeout defaults on the webhook #398

Merged

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jun 10, 2024

Kubebuilder doesn't always set the default of APITimeout, so with this patch we ensure that APITimeout field always has a valid value.

Kubebuilder doesn't always set the default of APITimeout, so with this
patch we ensure that APITimeout field always has a valid value.
@openshift-ci openshift-ci bot requested review from stuggi and viroel June 10, 2024 08:56
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1ab6bba into openstack-k8s-operators:main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants