Logging: Use ISO8601 timestamps #78
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Akrog The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Akrog
force-pushed
the
iso-timestamp
branch
2 times, most recently
from
df5a3cc
to
2fa325a
Compare
This patch disables the zap development logging mode that was the default in the Cinder operator. The new code does not set any zap options and only expects to read options from the command line. For development purposes it is convenient to run logging not only in development mode, but also increase the log levels and change the time encoding from epoc to iso8601 which is easier to read for humans, so 2 new make targets are added, `run-dev` and `docker-build-dev` which are similar to the `run` and `docker-build` targets. The `run-dev` target is different from the standard `run` because it will only build the operator if the binary doesn't exist.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Akrog: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This has been fixed somewhere else. |
This patch disables the zap development logging mode that was the
default in the Cinder operator.
The new code does not set any zap options and only expects to read
options from the command line.
For development purposes it is convenient to run logging not only in
development mode, but also increase the log levels and change the time
encoding from epoc to iso8601 which is easier to read for humans, so 2
new make targets are added,
run-devanddocker-build-devwhich aresimilar to the
runanddocker-buildtargets.The
run-devtarget is different from the standardrunbecause itwill only build the operator if the binary doesn't exist.