Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Order nodes when creating dnsdata #926

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Order nodes when creating dnsdata #926

merged 1 commit into from
Jun 7, 2024
+332 −1

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jun 7, 2024 •
edited
Loading

Otherwise dnsdata could be different in every reconciliation and this would result in a reconciliation loop as

  • NodeSet watches dnsmasq changes
  • dnsmasq watches dnsdata changes

Also adds a multinode kuttl test where we can test these things.

jira: https://issues.redhat.com/browse/OSPRH-7618

@openshift-ci openshift-ci bot requested review from stuggi and viroel June 7, 2024 02:24
@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@rabi
Copy link
Contributor Author

rabi commented Jun 7, 2024

/retest

@rabi
Order nodes when creating dnsdata
fe48062 
Otherwise dnsdata could be different in every reconciliation and
this would result in a reconciliation loop as
- NodeSet watches dnsmasq changes
- dnsmasq watches dnsdata changes

Also adds a multinode kuttl test where we can test these things.

Signed-off-by: rabi <ramishra@redhat.com>
@rabi
Copy link
Contributor Author

rabi commented Jun 7, 2024

/test dataplane-operator-build-deploy-kuttl

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b6b62cef73d5472ea43375ba290218d1

❌ openstack-k8s-operators-content-provider FAILURE in 10m 32s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@rabi
Copy link
Contributor Author

rabi commented Jun 7, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jun 7, 2024

/test functional

gibizer
gibizer approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense.

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rabi
Copy link
Contributor Author

rabi commented Jun 7, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit c70f433 into openstack-k8s-operators:main Jun 7, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gibizer gibizer gibizer approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@viroel viroel Awaiting requested review from viroel

Assignees

@gibizer gibizer

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rabi @gibizer