Document webhook logic reuse pattern #47
Conversation
| 3. Validation has multiple types, validation during create, update, or even | ||
| delete. The update validation has access to both the old and the new struct | ||
| value to be able to detect the change. |
There was a problem hiding this comment.
I would focus on this a bit more. Specifically, it would be a good idea to elaborate on requirements, that is MUST and MUST NOT, of each validation type.
There was a problem hiding this comment.
I'm not sure what kind of requirements you are after. Do you have an example?
There was a problem hiding this comment.
Sure. I was thinking along the lines of:
Create Validation MUST return error of the NewInvalid type, if it encounters any invalid section of the created data structure.
There was a problem hiding this comment.
Clarified it in the doc
|
Also, linking to an existing implementation of the pattern could be useful. |
| 3. Validation has multiple types, validation during create, update, or even | ||
| delete. The update validation has access to both the old and the new struct | ||
| value to be able to detect the change. |
There was a problem hiding this comment.
I'm not sure what kind of requirements you are after. Do you have an example?
gibizer
force-pushed
the
webhook-pattern
branch
2 times, most recently
from
d31737a
to
ec3a794
Compare
Done. |
The pattern is documented in openstack-k8s-operators/dev-docs#47
The pattern is documented in openstack-k8s-operators/dev-docs#47
* split up the validation calls towards the service CRDs to have a separate ValidateCreate and ValidateUpdate call * make sure that the service operators ValidateUpdate call gets the old version of the Spec struct so that they can compare The pattern is documented in openstack-k8s-operators/dev-docs#47
The pattern is documented in openstack-k8s-operators/dev-docs#47
* split up the validation calls towards the service CRDs to have a separate ValidateCreate and ValidateUpdate call * make sure that the service operators ValidateUpdate call gets the old version of the Spec struct so that they can compare The pattern is documented in openstack-k8s-operators/dev-docs#47
* split up the validation calls towards the service CRDs to have a separate ValidateCreate and ValidateUpdate call * make sure that the service operators ValidateUpdate call gets the old version of the Spec struct so that they can compare The pattern is documented in openstack-k8s-operators/dev-docs#47
|
The openstack-, ironic-, and nova-operator now aligned to this pattern. See openstack-k8s-operators/openstack-operator#383 for details. So I think we can merge this doc now |
No description provided.