Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edpm_libvirt]Enable os_enable_vtpm selinux boolean #537

Merged

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jan 16, 2024

To support VTPM with Selinux we need to enable the policy.

Related: OSPRH-2449
Related: OSPRH-2451

@gibizer
Copy link
Contributor Author

gibizer commented Jan 16, 2024

This is replicating https://review.opendev.org/c/openstack/tripleo-heat-templates/+/813431 from tripleo to support VTPM

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ansible.posix.seboolean:
name: os_enable_vtpm
persistent: true
state: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack this looks reasonable to me.

just noting this for later
we probably want to add an edpm_sebool role that will have a default set of bools to set tuple(bool_name, value)

for now i think this is fine

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/aeca007a594a4cd2adf18980be34b96c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 21s
podified-multinode-edpm-deployment-crc FAILURE in 1h 52m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 44m 21s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 11s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 54s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 06s
edpm-ansible-molecule-edpm_libvirt FAILURE in 7m 28s
edpm-ansible-molecule-edpm_nova FAILURE in 6m 55s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 50s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 18s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 07s

To support VTPM with Selinux we need to enable the policy.

Related: OSPRH-2449
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer
Copy link
Contributor Author

gibizer commented Jan 17, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 6074851 into openstack-k8s-operators:main Jan 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants