Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdoproject repo to get latest libvirt 10 version #558

Closed

Conversation

arxcruz
Copy link

@arxcruz arxcruz commented Feb 7, 2024

There is a bug on libvirt 9.10 and libvirt 10 which fixes this bug is
not yet available. In order to workaround this situation, the rdoproject
build latest libvirt 10 version on their repo and we are adding it here
in order to fix our long standing block on edpm jobs.
I used shell to configure the repo, because I wasn't able to find in the
ansible documentation how to do so with a .repo file.

@openshift-ci openshift-ci bot requested review from stuggi and viroel February 7, 2024 11:22
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arxcruz
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arxcruz added a commit to arxcruz/tcib that referenced this pull request Feb 7, 2024
arxcruz added a commit to arxcruz/tcib that referenced this pull request Feb 7, 2024
Testing libvirt downgrade with depends-on

Depends-On: openstack-k8s-operators/edpm-ansible#558
arxcruz added a commit to arxcruz/tcib that referenced this pull request Feb 7, 2024
Testing libvirt downgrade with depends-on

Depends-On: openstack-k8s-operators/edpm-ansible#558
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/adb64de0f2a44a9f9d7f2b95b4982cee

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 37m 34s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 59s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 48s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 48s
edpm-ansible-molecule-edpm_libvirt FAILURE in 6m 21s
edpm-ansible-molecule-edpm_nova FAILURE in 6m 31s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 46s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 45s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 29s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 4m 56s

@arxcruz arxcruz force-pushed the exclude-libvirtc branch 4 times, most recently from b1114ac to 1899668 Compare February 7, 2024 15:16
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/26077355996c4f0c8ea1e28c979b4174

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 37m 23s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 7m 55s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 47s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 07s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 12s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 33s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 9m 35s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 09s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 52s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 23s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 4m 55s

There is a bug on libvirt 9.10 and libvirt 10 which fixes this bug is
not yet available. In order to workaround this situation, the rdoproject
build latest libvirt 10 version on their repo and we are adding it here
in order to fix our long standing block on edpm jobs.
I used shell to configure the repo, because I wasn't able to find in the
ansible documentation how to do so with a .repo file.
@arxcruz arxcruz changed the title DNM - Testing exclude libvirt 9.10 Add rdoproject repo to update libvirt Feb 7, 2024
@arxcruz arxcruz changed the title Add rdoproject repo to update libvirt Add rdoproject repo to get latest libvirt 10 version Feb 7, 2024
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@arxcruz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pre-commit-test bf5a930 link true /test pre-commit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

arxcruz added a commit to arxcruz/tcib that referenced this pull request Feb 7, 2024
Testing libvirt downgrade with depends-on

Depends-On: openstack-k8s-operators/edpm-ansible#558
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d35ab19221bf44f0a1d250bda2e79f49

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 42s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 34m 46s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 3h 00m 40s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 54s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 08s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 41s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 54s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 9m 38s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 15s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 41s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 28s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 4m 55s

- name: Add master repository containing libvirt 10
shell:
cmd: |
dnf config-manager --add-repo https://trunk.rdoproject.org/centos9-master/delorean-deps-test.repo && dnf update -y
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we should add a fix related to centos here in this repo.
Can we do this in install_yamls or ci-framework instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya this should not be done in the production code this is a tempeory ci issue.

also I'm not sure that the rdo project is the correct place to pull this form
if we wanted newer libvirt we shoudl use the virt-preview corp repos

we don't maintain libvirt in rdo.
it is not the upstream of what lands in our downstream product
libvirt comes form rhel directly.
OSP had a libvirt package in osp 13 but not in 16 or 17

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seams like the wrong repo to work around this in

a better apprch would be to pin this in the ci job or via a package mirror not in the ansibel code

- name: Add master repository containing libvirt 10
shell:
cmd: |
dnf config-manager --add-repo https://trunk.rdoproject.org/centos9-master/delorean-deps-test.repo && dnf update -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya this should not be done in the production code this is a tempeory ci issue.

also I'm not sure that the rdo project is the correct place to pull this form
if we wanted newer libvirt we shoudl use the virt-preview corp repos

we don't maintain libvirt in rdo.
it is not the upstream of what lands in our downstream product
libvirt comes form rhel directly.
OSP had a libvirt package in osp 13 but not in 16 or 17

@arxcruz
Copy link
Author

arxcruz commented Feb 8, 2024

Closing in favor of #560

@arxcruz arxcruz closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants