-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rdoproject repo to get latest libvirt 10 version #558
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arxcruz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Testing libvirt downgrade with depends-on Depends-On: openstack-k8s-operators/edpm-ansible#558
Testing libvirt downgrade with depends-on Depends-On: openstack-k8s-operators/edpm-ansible#558
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/adb64de0f2a44a9f9d7f2b95b4982cee ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 45s |
b1114ac
to
1899668
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/26077355996c4f0c8ea1e28c979b4174 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 13s |
There is a bug on libvirt 9.10 and libvirt 10 which fixes this bug is not yet available. In order to workaround this situation, the rdoproject build latest libvirt 10 version on their repo and we are adding it here in order to fix our long standing block on edpm jobs. I used shell to configure the repo, because I wasn't able to find in the ansible documentation how to do so with a .repo file.
1899668
to
bf5a930
Compare
@arxcruz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Testing libvirt downgrade with depends-on Depends-On: openstack-k8s-operators/edpm-ansible#558
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d35ab19221bf44f0a1d250bda2e79f49 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 42s |
- name: Add master repository containing libvirt 10 | ||
shell: | ||
cmd: | | ||
dnf config-manager --add-repo https://trunk.rdoproject.org/centos9-master/delorean-deps-test.repo && dnf update -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should add a fix related to centos here in this repo.
Can we do this in install_yamls or ci-framework instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya this should not be done in the production code this is a tempeory ci issue.
also I'm not sure that the rdo project is the correct place to pull this form
if we wanted newer libvirt we shoudl use the virt-preview corp repos
we don't maintain libvirt in rdo.
it is not the upstream of what lands in our downstream product
libvirt comes form rhel directly.
OSP had a libvirt package in osp 13 but not in 16 or 17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seams like the wrong repo to work around this in
a better apprch would be to pin this in the ci job or via a package mirror not in the ansibel code
- name: Add master repository containing libvirt 10 | ||
shell: | ||
cmd: | | ||
dnf config-manager --add-repo https://trunk.rdoproject.org/centos9-master/delorean-deps-test.repo && dnf update -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya this should not be done in the production code this is a tempeory ci issue.
also I'm not sure that the rdo project is the correct place to pull this form
if we wanted newer libvirt we shoudl use the virt-preview corp repos
we don't maintain libvirt in rdo.
it is not the upstream of what lands in our downstream product
libvirt comes form rhel directly.
OSP had a libvirt package in osp 13 but not in 16 or 17
Closing in favor of #560 |
There is a bug on libvirt 9.10 and libvirt 10 which fixes this bug is
not yet available. In order to workaround this situation, the rdoproject
build latest libvirt 10 version on their repo and we are adding it here
in order to fix our long standing block on edpm jobs.
I used shell to configure the repo, because I wasn't able to find in the
ansible documentation how to do so with a .repo file.