Derive pci device_spec edpm_derive_pci_device_spec #597
Conversation
vcandapp
force-pushed
the
derive_device_spec
branch
5 times, most recently
from
83f2c57
to
c79be83
Compare
vcandapp
force-pushed
the
derive_device_spec
branch
from
c79be83
to
cfc39c3
Compare
vcandapp
changed the title
vcandapp
force-pushed
the
derive_device_spec
branch
2 times, most recently
from
f6cc507
to
5cf236a
Compare
| # under the License. | ||
|
|
||
| - name: Derive the SR-IOV device_spec config map for nic-partitionin | ||
| ansible.builtin.import_tasks: derive_pci.yml |
There was a problem hiding this comment.
@vcandapp please change derive_pci.yml file name like derive_pci_device_spec.yml.
There was a problem hiding this comment.
Changed file name for more clarity
| when: | ||
| - not sriov_device_spec_conf_check.stat.exists | ||
| become: true | ||
| block: |
There was a problem hiding this comment.
@vcandapp can we add one more task fof this block to print derived results. so that user can also use pod logs to create configmap for nova custom service.
There was a problem hiding this comment.
Added output debug log
| sriov_device_spec_map: "{{ edpm_derive_sriov_device_spec_list }}" | ||
| sriov_phydev_map: "{{edpm_derive_pci_device_spec_physmap_file }}" | ||
| sriov_device_spec_out_file: "{{ edpm_derive_pci_device_spec_conf_dir }}/{{ edpm_derive_pci_device_spec_conf_file }}" | ||
| register: derive_pci_devicespec |
There was a problem hiding this comment.
@vcandapp line 47 and 48 are not required.
There was a problem hiding this comment.
derive_pci_devicespec.rc will throw error.
There was a problem hiding this comment.
This will be needed
| - name: Check valid input for edpm_derive_sriov_device_spec_list | ||
| ansible.builtin.fail: | ||
| msg: "List of sriov device_spec cannot be empty - edpm_derive_sriov_device_spec_list" | ||
| when: edpm_derive_sriov_device_spec_list | length > 0 |
There was a problem hiding this comment.
@vcandapp Need to update condition length==0 for fail message.
|
|
||
| .. code-block:: YAML | ||
|
|
||
| - name: "Configure DDP Package" |
|
|
||
|
|
||
| def get_allocated_pci_addresses(configs): | ||
| alloc_pci_info = [] |
There was a problem hiding this comment.
same description missing
|
|
||
|
|
||
| def get_pci_passthrough_devicespec(user_config, pf, pci_addresses): | ||
| pci_passthrough_list = [] |
There was a problem hiding this comment.
same description missing
|
|
||
| def get_passthrough_config_for_all_pf(user_config, | ||
| system_configs, | ||
| allocated_pci): |
There was a problem hiding this comment.
same description missing
| configs = [] | ||
| src_config = "" | ||
| # Currently only "device_spec" is valid | ||
| valid_spec = ('device_spec') |
There was a problem hiding this comment.
@vcandapp can we reuse this variable PASSTHROUGH_DEVSPEC_KEY instead of valid_spec new variable again?
There was a problem hiding this comment.
No action, This function is removed now
| sriov_phydev_map=None): | ||
| pci_passthrough = {} | ||
| system_configs = get_sriov_configs() | ||
| user_configs = sriov_device_spec |
There was a problem hiding this comment.
@vcandapp remove this line and specify user_configs as _run_derive_pci function argument sriov_device_spec,?
since no user_configs updates done. only for reading purpose.
| - List of SR-IOV device_spec | ||
| type: list | ||
| required: true | ||
| default: '' |
There was a problem hiding this comment.
@vcandapp used required but default is empty. mutually exclusive and get internal error
| - ConfigMap file to be used in nic-partitioned deployment | ||
| type: str | ||
| required: true | ||
| default: '/var/lib/config-data/ansible-generated/derive_devicespec/20-sriov-nova.conf' |
| type: str | ||
| required: false | ||
| default: '' | ||
| sriov_nova_conf_file: |
There was a problem hiding this comment.
sriov_device_spec_out_file is used in derive pci file and here sriov_nova_conf_file. need to update sync
vcandapp
force-pushed
the
derive_device_spec
branch
6 times, most recently
from
a055be7
to
cbce0c2
Compare
| changed_when: derive_pci_devicespec.rc == 0 | ||
| - name: Print result of derived device_spec | ||
| debug: | ||
| msg: "{{ derive_pci_devicespec }}" |
There was a problem hiding this comment.
@vcandapp Please use derive_pci_devicespec.device_spec instead of complete details
vcandapp
force-pushed
the
derive_device_spec
branch
4 times, most recently
from
04c1d18
to
02ec65d
Compare
|
/lgtm |
|
/approve |
|
Did E-2-E testing with this PR in nic partitioned deployement, and here are the verified logs: [WARNING]: running playbook inside collection osp.edpm PLAY [Derive sriov device_spec] ************************************************ TASK [Gathering Facts] ********************************************************* TASK [osp.edpm.edpm_derive_pci_device_spec : Validating arguments against arg spec 'main' - The main entry point for the edpm_derive_pci_device_spec role.] *** TASK [osp.edpm.edpm_derive_pci_device_spec : Check valid input for edpm_derive_sriov_device_spec_list] *** TASK [osp.edpm.edpm_derive_pci_device_spec : Create neutron-sriov-agent directories] *** TASK [osp.edpm.edpm_derive_pci_device_spec : Check if edpm node has the sriov nova conf] *** TASK [osp.edpm.edpm_derive_pci_device_spec : Run derive_pci_passthrough_devicespec] *** TASK [osp.edpm.edpm_derive_pci_device_spec : Print result of derived device_spec] *** PLAY RECAP Gathering Facts --------------------------------------------------------- 1.51s |
This role will generate the pci device_spec for sriov nic partitioning deployment. The generated config file should be used to create device_spec configmap for custom nova dataplane service. *Added basic molecule test *Unit tests
vcandapp
force-pushed
the
derive_device_spec
branch
from
02ec65d
to
5186ba0
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, Jaganathancse, vcandapp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This role will generate the pci device_spec for sriov nic partitioning deployment.
The generated config file should be used to create device_spec configmap for custom nova dataplane service.
This has been re-factored from PR