Setting quota limits fails with certificate error #532
Conversation
|
/hold beta freeze |
There was a problem hiding this comment.
do we need the GetAdminServiceClient() in here? can we just use the GetScopedAdminServiceClient() from keystone? openstack-k8s-operators/keystone-operator#417 will add cert validation for the client connection.
Interesting, I didn't know about that function, especially that we can pass the scope! I will try that and it would simplify the code here in the operator, and we won't have to worry about the tls parameter (and duplicating such code). |
fmount
force-pushed
the
quota_tls
branch
2 times, most recently
from
773f128
to
f05321b
Compare
|
@stuggi thank you this was a great hint! I can pass the scope I need and get a client from keystone. I just tested it and works as expected! |
|
/test glance-operator-build-deploy-kuttl |
This patch fixes the interaction with keystone when quota is registered or updated. As per [1], this change solves the problem by getting a client from keystone and passing the right scope. Jira: [OSPRH-6766](https://issues.redhat.com/browse/OSPRH-6766) [1]https://github.com/openstack-k8s-operators/keystone-operator/blob/main/api/v1beta1/keystoneapi.go#L143 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 33be9d7
into
openstack-k8s-operators:main
This patch fixes the interaction with keystone when quota is registered. As in [1], this change solves the problem by getting a scoped client from keystone.
Fixes: OSPRH-6766
[1]https://github.com/openstack-k8s-operators/keystone-operator/blob/main/api/v1beta1/keystoneapi.go#L143