Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 00-config (including barbican related config) #533

Merged
merged 1 commit into from
May 20, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented May 17, 2024

Somehow the 00-config template introduced by PRs [1][2] has been
reverted. This patch restores the missing file content.

Fixes: OSPRH-7155
[1] #385
[2] #378

@fmount fmount requested review from Akrog and konan-abhi May 17, 2024 20:27
@openshift-ci openshift-ci bot requested review from stuggi and viroel May 17, 2024 20:27
@fmount
Copy link
Contributor Author

fmount commented May 17, 2024

/hold

Somehow the 00-config template introduced by PRs [1][2] has been
reverted. This patch restores the missing file content.

[1] openstack-k8s-operators#385
[2] openstack-k8s-operators#378

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount changed the title Restore key_manager and barbican related config Restore 00-config (including barbican related config) May 18, 2024
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor Author

fmount commented May 20, 2024

merging after beta freeze

@openshift-merge-bot openshift-merge-bot bot merged commit de21705 into openstack-k8s-operators:main May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants