Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployment on community distro okd #648

Merged
merged 1 commit into from Dec 13, 2023

Conversation

amoralej
Copy link
Contributor

@amoralej amoralej commented Dec 1, 2023

This patch adds support to run deploy openstack operators in okd openshift distro. The main differences are related to the installation of external operators metallb, nmstate and cert-manager as openshift installation is based on the redhat-operators catalog which is not available in okd.

In order to implement it, I am adding a new parameter OKD which defaults to 'false' and should be 'true' to enable okd. I am trying to isolate the differences in separate scripts to avoid overcomplicating the scripts for deployment on openshift.

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

Hi @amoralej. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fao89
Copy link
Contributor

fao89 commented Dec 6, 2023

/ok-to-test

This patch adds support to run deploy openstack operators in okd
openshift distro. The main differences are related to the installation
of external operators metallb, nmstate and cert-manager as openshift
installation is based on the redhat-operators catalog which is not
available in okd.

In order to implement it, I am adding a new parameter OKD which defaults
to 'false' and should be 'true' to enable okd. I am trying to isolate
the differences in separate scripts to avoid overcomplicating the
scripts for deployment on openshift.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/848bee083c93402ab638354b5b84d5cf

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 50s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 3s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 26s
content-provider-data-plane-adoption-OSP-17-to-extracted-crc RETRY_LIMIT in 4s

@amoralej
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e669d3ef49e4f2cbe8633a6cebc4704

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 27s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 12m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 35s
content-provider-data-plane-adoption-OSP-17-to-extracted-crc FAILURE in 1h 53m 07s

@fao89
Copy link
Contributor

fao89 commented Dec 13, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/713e2125d2204ee784b5384335b3d9c3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 29m 06s
install-yamls-crc-podified-edpm-baremetal FAILURE in 49m 37s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 1h 37m 32s
✔️ content-provider-data-plane-adoption-OSP-17-to-extracted-crc SUCCESS in 2h 12m 49s

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fao89
Copy link
Contributor

fao89 commented Dec 13, 2023

/override rdoproject.org/github-check

all the tests passed in different runs

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

@fao89: Overrode contexts on behalf of fao89: rdoproject.org/github-check

In response to this:

/override rdoproject.org/github-check

all the tests passed in different runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9db37fc into openstack-k8s-operators:main Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants