Optional host macvlan for storage network #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an optional environmental variable called `NETWORK_STORAGE_MACVLAN` that when set will create a macvlan on top of the storage VLAN network to hold the IPs instead of the VLAN itself. This allows host to/from pod network communication on the same host using the storage VLAN. This is necessary for example when using Cinder's LVM driver with the iSCSI transport protocol and using the IP assigned to the pod's storage network attachment. The iscsi initiator (client) is run on the host, but it won't have network access to the iSCSI target port that gets opened in the cinder volume network namespace. We don't default to always create the macvlan because we are also introducing an alternative solution in the cinder-operator that will work for now (until we move the iSCSI target creation to privsep). This alternate solution requires the human operator to configure the cinder backend to use the host's storage network IP directly (the operator will make internally required changes to make that work).
Akrog
changed the title
fao89
approved these changes
Feb 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, Akrog, fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2fbbe00
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an optional environmental variable called
NETWORK_STORAGE_MACVLANthat when set will create a macvlan on top of the storage VLAN network to hold the IPs instead of the VLAN itself.This allows host to/from pod network communication on the same host using the storage VLAN.
This is necessary for example when using Cinder's LVM driver with the iSCSI transport protocol and using the IP assigned to the pod's storage network attachment.
The iscsi initiator (client) is run on the host, but it won't have network access to the iSCSI target port that gets opened in the cinder volume network namespace.
We don't default to always create the macvlan because LVM is a Proof of Concept backend that should not be used in production for serious workloads.
An example of how to use this is to use the existing cinder-operator LVM iSCSI sample, but changing how we deploy the operators:
Related cinder-operator PR: openstack-k8s-operators/cinder-operator#338