enable use of service_user tokens #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanMooney
commented
Jan 9, 2024
juliakreger
reviewed
Jan 9, 2024
This change also removes outdated todo comments from the init container script. As part of CVE-2023-2088 a hardening recommendation was made to start enforce that the service token user must have the service role. This change updates the ironic config to enable that enfrocement. Closes: OSPRH-3058 Closes: OSPRH-191
SeanMooney
force-pushed
the
service_user_config
branch
from
403199d
to
f6e1ff0
Compare
|
/test ironic-operator-build-deploy-tempest |
hjensas
approved these changes
Jan 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ironic-operator-build-deploy-kuttl the kuttl job failed because it failed to pull the required container images |
openshift-merge-bot
bot
merged commit e193fe0
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable use of service_user tokens role enforcement
This change also removes outdated todo comments
from the init container script.
As part of GHSA-fvf4-jv3j-73mq a hardening recommendation was made
to start enforce that the service token user must have the service
role. This change updates the ironic config to enable that enfrocement.
Closes: OSPRH-3058
Closes: OSPRH-191