Manage PVCs in the conductor StatefulSet #438
Merged
+25
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjensas
reviewed
Jun 17, 2024
steveb
changed the title
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ea409a7279b14ba99f6701ccdadc7e81 ✔️ noop SUCCESS in 0s |
hjensas
reviewed
Jun 18, 2024
The intent is for each conductor pod to have its own volume to store /var/lib/ironic state. However currently a single PVC is created and the resulting volume is shared across conductors. This change moves the PVC creation to be managed by the StatefulSet, so that PVC replicas match pod replicas. ReadWriteMany is not required for these volumes, and we required the control plane to not provide volumes of this type, so this change also switches to ReadWriteOnce. This fixes OSPRH-7688. Authored-By: Steve Baker <sbaker@redhat.com> Co-Authored-By: Harald Jensås <hjensas@redhat.com> Jira: OSPRH-7688
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliakreger, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 1560412
into
openstack-k8s-operators:main
8 checks passed
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is for each conductor pod to have its own volume to store
/var/lib/ironic state. However currently a single PVC is created and the
resulting volume is shared across conductors. This change moves the PVC
creation to be managed by the StatefulSet, so that PVC replicas match
pod replicas.
ReadWriteMany is not required for these volumes, and we required the
control plane to not provide volumes of this type, so this change also
switches to ReadWriteOnce. This fixes OSPRH-7688.
Jira: OSPRH-7688