Create EDP Secret for Neutron OVN Agent #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelyatin
added a commit
to openstack-k8s-operators/dataplane-operator
that referenced
this pull request
Oct 18, 2023
Depends-On: openstack-k8s-operators/neutron-operator#231 Depends-On: openstack-k8s-operators/edpm-ansible#463 Related-Issue: OSP-26191
booxter
approved these changes
Oct 20, 2023
| envVars *map[string]env.Setter, | ||
| ) error { | ||
| nbCluster, err := ovnclient.GetDBClusterByType(ctx, h, instance.Namespace, map[string]string{}, ovnclient.NBDBType) | ||
| if err != nil { |
There was a problem hiding this comment.
I kinda hate the amount of copy-paste here. I wonder if it's a "Go way" or we can e.g. introduce a deleteExternalSecret wrapper that would handle logging.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: booxter, karelyatin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
OVN NB and SB DB connection strings are exported with this secret as these are required by neutron-ovn-agent[1]. [1] openstack-k8s-operators/edpm-ansible#463 Related-Issue: OSP-26191
karelyatin
added a commit
to openstack-k8s-operators/dataplane-operator
that referenced
this pull request
Oct 23, 2023
Depends-On: openstack-k8s-operators/neutron-operator#231 Depends-On: openstack-k8s-operators/edpm-ansible#463 Related-Issue: OSP-26191
|
/lgtm |
karelyatin
added a commit
to karelyatin/dataplane-operator
that referenced
this pull request
Oct 23, 2023
Depends-On: openstack-k8s-operators/neutron-operator#231 Depends-On: openstack-k8s-operators/edpm-ansible#463 Related-Issue: OSP-26191
openshift-ci
bot
merged commit 2da5584
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVN NB and SB DB connection strings are exported with this secret as these are required by neutron-ovn-agent[1].
[1] openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191