[api]ensure sidecar terminates on SIGTERM #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelyatin
reviewed
Nov 27, 2023
We noticed that nova-api and nova-metadata pods do not immediately terminate on delete as the logging sidecar ignores SIGTERM. This PR adds the usage of dump-init to the sidecar command to ensure it handles SIGTERM properly
gibizer
force-pushed
the
use-dump-init-for-side-car
branch
from
1de2b6d
to
01b2a53
Compare
|
SeanMooney
approved these changes
Nov 27, 2023
| @@ -129,9 +129,16 @@ func StatefulSet( | |||
| { | |||
| Name: instance.Name + "-log", | |||
| Command: []string{ | |||
| "/bin/bash", | |||
There was a problem hiding this comment.
so the entrypoint in the kolla contianer is
Entrypoint: "dumb-init --single-child --"
so i was expecting command to map to docker/podmans command
it would appear that k8s/openshfit is not following the normal rules
for how entrypoint and command interact
https://stackoverflow.com/a/66967227
so when i orgianlly wrote this i was expect it to be wrapped in dumb init already
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cee3fe0
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that nova-api and nova-metadata pods do not immediately terminate on delete as the logging sidecar ignores SIGTERM. This PR adds the usage of dump-init to the sidecar command to ensure it handles SIGTERM properly
Fixes: OSPRH-770