Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really use cloud-admin user for local ansible task #710

Conversation

olliewalsh
Copy link
Contributor

This appeared to be working when I manually tested it but is not. Turns out the reason root owns the files is tripleo-deploy.sh sets ANSIBLE_BECOME="True". We have to expliciltly disable it if we want the current user.

Fix this for the stack_action_playbook generation. Other cases that hit this such as ceph-ansible will need to be fixed in upstream t-h-t.

This appeared to be working when I manually tested it but is not.
Turns out the reason root owns the files is tripleo-deploy.sh sets
ANSIBLE_BECOME="True". We have to expliciltly disable it if we want
the current user.

Fix this for the stack_action_playbook generation. Other cases that hit this
such as ceph-ansible will need to be fixed in upstream t-h-t.
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Dec 2, 2022

/cherry-pick v1.3.x

@openshift-cherrypick-robot

@stuggi: once the present PR merges, I will cherry-pick it on top of v1.3.x in a new PR and assign it to you.

In response to this:

/cherry-pick v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stuggi: new pull request created: #711

In response to this:

/cherry-pick v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants