-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempest-extras]Add barbican tempest plugin #113
[tempest-extras]Add barbican tempest plugin #113
Conversation
The whitebox tempest plugin actually depends on the barbican tempest plugin otherwise the vTPM tests are failing with cls.os_primary.secrets_client = service_clients.secret_v1.SecretClient( AttributeError: 'ServiceClients' object has no attribute 'secret_v1' So this patch adding it.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/57d175f545e3466996857e9ad179d7f8 ✔️ tcib-build-containers SUCCESS in 53m 15s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6443b7574b894d369c07635d0caca0ac ✔️ tcib-build-containers SUCCESS in 2h 03m 35s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/237073bf7c844cd1a639a2c1365bd4ee ✔️ tcib-build-containers SUCCESS in 2h 07m 25s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0752f80031264012bb380e80a12170a0 ✔️ tcib-build-containers SUCCESS in 1h 50m 08s |
recheck do we have a problem with the baremetal job?
|
Looks like https://review.rdoproject.org/r/c/config/+/51102 has broken the job. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7e42b39c4a2940e39c6f75fb29560a90 ❌ tcib-build-containers TIMED_OUT in 59m 17s |
recheck |
@gibizer, just an idea. Maybe if barbican-tempest-plugin is a dependency for whitebox-tempest-plugin then it should be added to the requirements upstream as well [1]. [1] https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/requirements.txt |
good idea, I will push a fix upstream |
https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/903680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, kopecmartin, viroel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b8d753
into
openstack-k8s-operators:main
The whitebox tempest plugin actually depends on the barbican tempest plugin otherwise the vTPM tests are failing with
So this patch adding it.
Implements: https://issues.redhat.com/browse/OSPRH-2451