Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempest-extras]Add barbican tempest plugin #113

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Dec 13, 2023

The whitebox tempest plugin actually depends on the barbican tempest plugin otherwise the vTPM tests are failing with

    cls.os_primary.secrets_client = service_clients.secret_v1.SecretClient(
AttributeError: 'ServiceClients' object has no attribute 'secret_v1'

So this patch adding it.

Implements: https://issues.redhat.com/browse/OSPRH-2451

The whitebox tempest plugin actually depends on the barbican tempest
plugin otherwise the vTPM tests are failing with

    cls.os_primary.secrets_client = service_clients.secret_v1.SecretClient(
AttributeError: 'ServiceClients' object has no attribute 'secret_v1'

So this patch adding it.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/57d175f545e3466996857e9ad179d7f8

✔️ tcib-build-containers SUCCESS in 53m 15s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 4s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 4s

@gibizer
Copy link
Contributor Author

gibizer commented Dec 13, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6443b7574b894d369c07635d0caca0ac

✔️ tcib-build-containers SUCCESS in 2h 03m 35s
tcib-crc-podified-edpm-baremetal FAILURE in 47m 07s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 27s

@gibizer
Copy link
Contributor Author

gibizer commented Dec 13, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/237073bf7c844cd1a639a2c1365bd4ee

✔️ tcib-build-containers SUCCESS in 2h 07m 25s
tcib-crc-podified-edpm-baremetal FAILURE in 1h 21m 08s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 12s

@gibizer
Copy link
Contributor Author

gibizer commented Dec 14, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0752f80031264012bb380e80a12170a0

✔️ tcib-build-containers SUCCESS in 1h 50m 08s
tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 32s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 28s

@gibizer
Copy link
Contributor Author

gibizer commented Dec 14, 2023

recheck

do we have a problem with the baremetal job?

/tmp/ensure_logged.sh: line 15: /usr/bin/oc: No such file or directory
Can not login to the CRC cluster. Sleeping...

@rabi
Copy link
Collaborator

rabi commented Dec 14, 2023

recheck

do we have a problem with the baremetal job?

/tmp/ensure_logged.sh: line 15: /usr/bin/oc: No such file or directory
Can not login to the CRC cluster. Sleeping...

Looks like https://review.rdoproject.org/r/c/config/+/51102 has broken the job.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7e42b39c4a2940e39c6f75fb29560a90

tcib-build-containers TIMED_OUT in 59m 17s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job tcib-build-containers
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job tcib-build-containers

@gibizer
Copy link
Contributor Author

gibizer commented Dec 14, 2023

recheck
based on slack the job should be good now

@lpiwowar
Copy link
Contributor

@gibizer, just an idea. Maybe if barbican-tempest-plugin is a dependency for whitebox-tempest-plugin then it should be added to the requirements upstream as well [1].

[1] https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/requirements.txt

@gibizer
Copy link
Contributor Author

gibizer commented Dec 14, 2023

@gibizer, just an idea. Maybe if barbican-tempest-plugin is a dependency for whitebox-tempest-plugin then it should be added to the requirements upstream as well [1].

[1] https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/requirements.txt

good idea, I will push a fix upstream

@gibizer
Copy link
Contributor Author

gibizer commented Dec 14, 2023

@gibizer, just an idea. Maybe if barbican-tempest-plugin is a dependency for whitebox-tempest-plugin then it should be added to the requirements upstream as well [1].
[1] https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/requirements.txt

good idea, I will push a fix upstream

https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/903680

Copy link
Contributor

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viroel
Copy link
Contributor

viroel commented Dec 18, 2023

/approve

needed for openstack-k8s-operators/openstack-operator#589

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, kopecmartin, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6b8d753 into openstack-k8s-operators:main Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants