Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary TLS cert creation on container startup #127

Merged

Conversation

olliewalsh
Copy link
Contributor

Kolla is generating a self-signed cert on container startup which we do not use. This will burn considerable resources and time for every container start.
If we have mounted a custom ssl.conf skip the step.

Kolla is generating a self-signed cert on container startup
which we do not use. This will burn considerable resources and time
for every container start.
If we have mounted a custom ssl.conf skip the step.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/30643d65920847caa76be8f905b0544e

✔️ tcib-build-containers SUCCESS in 1h 53m 37s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 12m 36s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 45s

@stuggi
Copy link
Contributor

stuggi commented Jan 31, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a5179ea39802457c80a6749e1974dce9

✔️ tcib-build-containers SUCCESS in 2h 11m 07s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 15m 47s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 44s

@olliewalsh
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/081b470366ed4e7f9d73ea916885f5c3

tcib-build-containers FAILURE in 9m 02s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job tcib-build-containers
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job tcib-build-containers

@rabi
Copy link
Collaborator

rabi commented Feb 1, 2024

recheck

Copy link
Collaborator

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 1, 2024
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 1, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1a626587d1804049b41e42cad568630f

tcib-build-containers FAILURE in 9m 00s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job tcib-build-containers
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job tcib-build-containers

@lewisdenny
Copy link

recheck

Recheck with autohold to check logs

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/20b41505cab0442dbe4d920d4b62eca4

✔️ tcib-build-containers SUCCESS in 2h 00m 46s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 15m 44s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 21s

@lewisdenny
Copy link

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/129453872bab435da31c1056f537df11

✔️ tcib-build-containers SUCCESS in 1h 56m 30s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 15m 55s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 34s

@olliewalsh
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9f22f40a530141118e7511fcf6b0b61c

✔️ tcib-build-containers SUCCESS in 2h 02m 01s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 20m 23s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 59m 53s

@stuggi
Copy link
Contributor

stuggi commented Feb 2, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/584c553df02645b8b85ec4f9fa543093

✔️ tcib-build-containers SUCCESS in 2h 01m 28s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 18m 09s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 30s

@stuggi
Copy link
Contributor

stuggi commented Feb 5, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/29f4abb5f2fa48039bad3a4c077b7b30

✔️ tcib-build-containers SUCCESS in 1h 58m 50s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 14m 21s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 40s

@olliewalsh
Copy link
Contributor Author

recheck should be fixed in latest centos steam 9 libvirt rpm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fecc2d10a3f541549e49289c84fa63c1

✔️ tcib-build-containers SUCCESS in 1h 48m 11s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 08m 21s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 06s

@olliewalsh
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/82edb80b54c7472d88ec2632a49adbd9

✔️ tcib-build-containers SUCCESS in 1h 50m 16s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 09m 58s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 59s

@lewisdenny
Copy link

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa8 in position 2: invalid start byte

https://logserver.rdoproject.org/27/127/e7992da92f6f67327ffbf593a64b712e36b04cc6/github-check/tcib-podified-multinode-edpm-deployment-crc/bc902ae/controller/ci-framework-data/logs/192.168.122.100/log/containers/nova/nova-compute.log

https://issues.redhat.com/browse/RHEL-20609

Looks like the fix will come in libvirt-10.0.0-1.el9 and we're still pulling 9.10.0

@olliewalsh
Copy link
Contributor Author

olliewalsh commented Feb 7, 2024

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa8 in position 2: invalid start byte

https://logserver.rdoproject.org/27/127/e7992da92f6f67327ffbf593a64b712e36b04cc6/github-check/tcib-podified-multinode-edpm-deployment-crc/bc902ae/controller/ci-framework-data/logs/192.168.122.100/log/containers/nova/nova-compute.log

https://issues.redhat.com/browse/RHEL-20609

Looks like the fix will come in libvirt-10.0.0-1.el9 and we're still pulling 9.10.0

Indeed, why aren't we installing that? It's in the centos stream mirrors now ah, was mis-reading the version, thought it was fixed in 9.10, not 10.0

@olliewalsh
Copy link
Contributor Author

/hold until #130 lands

@olliewalsh
Copy link
Contributor Author

recheck workaround in openstack-k8s-operators/edpm-ansible#560

@olliewalsh
Copy link
Contributor Author

/remove-hold

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/02972366a2e8482e92dad418623f931e

✔️ tcib-build-containers SUCCESS in 2h 11m 19s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 21m 16s
tcib-podified-multinode-edpm-deployment-crc RETRY_LIMIT in 4s

@olliewalsh
Copy link
Contributor Author

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/71c641ea267e4b448f3a46a1430599dc

✔️ tcib-build-containers SUCCESS in 1h 47m 53s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 1h 09m 13s
tcib-podified-multinode-edpm-deployment-crc FAILURE in 57m 58s

@rabi
Copy link
Collaborator

rabi commented Feb 13, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 2f831f3 into openstack-k8s-operators:main Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants