[Tobiko] Add tcpdump and prepare to run containers as root #131
Conversation
Running the tobiko container as rootless is not possible because some tobiko tests need to capture traffic on an interface from the test machine, i.e. from the tobiko container. Depends-On: openstack-k8s-operators/tcib#131
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/894a6f63f85749e48051a64b4688828c ✔️ tcib-build-containers SUCCESS in 1h 41m 58s |
|
From the standpoint of the test-operator this change is backwards compatible and the tests that were working previously with the test-operator didn't break. So LGTM! |
Some tobiko tests capture traffic on the tobiko container where tests are executed using tcpdump. For that reason: - tcpdump needs to be added to the list of packages that need to be installed on the tobiko image. - the container will need to be executed with root permissions, so the run_tobiko.sh script needs to manage properly the mounted files and directories.
eduolivares
force-pushed
the
add-tcpdump2tobiko
branch
from
16df5b0
to
89ac7bf
Compare
|
/lgtm |
|
/assign @raukadah |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eduolivares, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4375bf0
into
openstack-k8s-operators:main
Some tobiko tests capture traffic on the tobiko container where tests are executed using tcpdump.
For that reason: