Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tobiko] Fix extraction of log dir name #153

Conversation

lpiwowar
Copy link
Contributor

@lpiwowar lpiwowar commented Mar 12, 2024

Currently we look for the logs based on the name of testenv but we do not take into account the fact that the testenv can have the following format:

'functional -- tobiko/tests/functional/podified/test_topology.py'

This patch ensures that we take only the first part of the testenv name ('functional') into account when copying the logs.

Depends-On: openstack-k8s-operators/ci-framework#1254

Currently we look for the logs based on the name of testenv but we do
not take into account the fact that the testenv can have the following
format:

'functional -- tobiko/tests/functional/podified/test_topology.py'

This patch ensures that we take only the first part of the testenv name
('functional') into account when copying the logs.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ab1bbede33894036bc3d0d972412a741

tcib-build-containers FAILURE in 4m 57s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job tcib-build-containers
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job tcib-build-containers

@eduolivares
Copy link
Contributor

@lpiwowar I think you need to add:
Depends-On: openstack-k8s-operators/ci-framework#1254

@lpiwowar
Copy link
Contributor Author

recheck

Copy link
Contributor

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eduolivares, kopecmartin, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d65b419 into openstack-k8s-operators:main Mar 12, 2024
5 checks passed
@lpiwowar lpiwowar deleted the fix/tobiko-log-dir-name branch March 12, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants