Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action groups #2

Closed
wants to merge 1 commit into from
Closed

Update action groups #2

wants to merge 1 commit into from

Conversation

s-hertel
Copy link

The format expected by ansible/ansible#67291 changed, so just updating these here.

@openstack-gerrit
Copy link

Thank you for contributing to openstack/ansible-collections-openstack!

openstack/ansible-collections-openstack uses Gerrit for code review.

If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
https://docs.openstack.org/infra/manual/developers.html#getting-started

Otherwise please visit
https://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

- os_zone

action_groups_redirection:
os:
Copy link
Contributor

@sshnaidm sshnaidm Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-hertel I have a question about redirect:
should it be instead:

action_groups_redirection:
  openstack:
    redirect: os

If so, can we just drop here section of openstack and leave only os? It's actually almost duplicate each of other. (while os includes openstack)
Or maybe I miss something in redirection?
Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change was in flux still in ansible/ansible at the time, and action_groups_redirection needs to be removed from this now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created patch in Gerrit:
Move action_group to runtime https://review.opendev.org/735977

openstack-mirroring pushed a commit that referenced this pull request Jun 17, 2020
from #2

Change-Id: I82c68c31bccd54d5c2624bf2081820c09791b466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants