Progress bar causes intermittent test failures

I'm seeing intermittent failures on:

  glance.tests.functional.test_misc:TestMiscellaneous
    test_api_treats_size_as_a_normal_property

with a 'glance show' command failing with:

  STDERR: /bin/sh: line 1: $'\b\b\b\b\b\b[100%]': command not found

apparently due to leakage of the progress bar output associated
with the previously executed 'glance add' command.

For the same reason, I see failures on:

  glance.tests.functional.test_bin_glance:TestBinGlance
    test_show_image_format

Work-around by enabling silent-upload so that test are reliably green.

Change-Id: Ib23e0a1f042d8e7950bddc485696a69338cf8620

glance/tests/functional/test_bin_glance.py

@@ -880,12 +880,8 @@ def test_show_image_format(self):
             image_file.write("XXX")
             image_file.flush()
             image_file_name = image_file.name
-            cmd = "bin/glance --port=%d add is_public=True"\
-                  " disk_format=raw container_format=ovf " \
-                  " name=MyImage < %s" % (api_port, image_file_name)
-            cmd = minimal_add_command(api_port,
-                                      'MyImage',
-                                      '< %s' % image_file_name)
+            suffix = ' --silent-upload < %s' % image_file_name
+            cmd = minimal_add_command(api_port, 'MyImage', suffix)
 
             exitcode, out, err = execute(cmd)
 

glance/tests/functional/test_misc.py

@@ -130,9 +130,8 @@ def test_api_treats_size_as_a_normal_property(self):
             image_file.write("XXX")
             image_file.flush()
             image_file_name = image_file.name
-            cmd = minimal_add_command(self.api_port,
-                                      'MyImage',
-                                      'size=12345 < %s' % image_file_name)
+            suffix = 'size=12345 --silent-upload < %s' % image_file_name
+            cmd = minimal_add_command(self.api_port, 'MyImage', suffix)
 
             exitcode, out, err = execute(cmd)