Change page header heading to H1

Partially implements: blueprint detail-pages-ia Change-Id: I42b58e73fd3990c5b5e197e5694eb77eeb42f77c
openstack · Sep 11, 2014 · 61f0198 · 61f0198
1 parent 354c0c1
commit 61f0198
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/horizon/templates/horizon/common/_domain_page_header.html b/horizon/templates/horizon/common/_domain_page_header.html
@@ -1,11 +1,11 @@
 {% load i18n %}
 {% block page_header %}
   <div class='page-header'>
-    <h2>
+    <h1>
     {% if request.session.domain_context_name %}
       <em>{{ request.session.domain_context_name }}:</em>
     {% endif %}
     {{ title }}
-    </h2>
+    </h1>
   </div>
 {% endblock %}
diff --git a/horizon/templates/horizon/common/_page_header.html b/horizon/templates/horizon/common/_page_header.html
@@ -1,6 +1,6 @@
 {% load i18n %}
 {% block page_header %}
   <div class='page-header'>
-    <h2>{{ title }}</h2>
+    <h1>{{ title }}</h1>
   </div>
 {% endblock %}
diff --git a/openstack_dashboard/dashboards/admin/volumes/snapshots/tests.py b/openstack_dashboard/dashboards/admin/volumes/snapshots/tests.py
@@ -59,7 +59,7 @@ def test_get_volume_snapshot_details(self):
         res = self.client.get(url)
 
         self.assertContains(res,
-                            "<h2>Volume Snapshot Details: %s</h2>" %
+                            "<h1>Volume Snapshot Details: %s</h1>" %
                             snapshot.name,
                             1, 200)
         self.assertContains(res, "<dd>test snapshot</dd>", 1, 200)

diff --git a/openstack_dashboard/dashboards/project/images/images/tests.py b/openstack_dashboard/dashboards/project/images/images/tests.py
@@ -227,7 +227,7 @@ def test_image_detail_get(self):
                             'project/images/images/detail.html')
         self.assertEqual(res.context['image'].name, image.name)
         self.assertEqual(res.context['image'].protected, image.protected)
-        self.assertContains(res, "<h2>Image Details: %s</h2>" % image.name,
+        self.assertContains(res, "<h1>Image Details: %s</h1>" % image.name,
                             1, 200)
 
     @test.create_stubs({api.glance: ('image_get',)})

diff --git a/openstack_dashboard/dashboards/project/volumes/backups/tests.py b/openstack_dashboard/dashboards/project/volumes/backups/tests.py
@@ -100,7 +100,7 @@ def test_volume_backup_detail_get(self):
         res = self.client.get(url)
 
         self.assertContains(res,
-                            "<h2>Volume Backup Details: %s</h2>" %
+                            "<h1>Volume Backup Details: %s</h1>" %
                             backup.name,
                             1, 200)
         self.assertContains(res, "<dd>%s</dd>" % backup.name, 1, 200)
@@ -141,7 +141,7 @@ def test_volume_backup_detail_with_missing_volume(self):
         res = self.client.get(url)
 
         self.assertContains(res,
-                            "<h2>Volume Backup Details: %s</h2>" %
+                            "<h1>Volume Backup Details: %s</h1>" %
                             backup.name,
                             1, 200)
         self.assertContains(res, "<dd>%s</dd>" % backup.name, 1, 200)

diff --git a/openstack_dashboard/dashboards/project/volumes/snapshots/tests.py b/openstack_dashboard/dashboards/project/volumes/snapshots/tests.py
@@ -152,7 +152,7 @@ def test_volume_snapshot_detail_get(self):
         res = self.client.get(url)
 
         self.assertContains(res,
-                            "<h2>Volume Snapshot Details: %s</h2>" %
+                            "<h1>Volume Snapshot Details: %s</h1>" %
                             snapshot.name,
                             1, 200)
         self.assertContains(res, "<dd>test snapshot</dd>", 1, 200)

diff --git a/openstack_dashboard/dashboards/project/volumes/volumes/tests.py b/openstack_dashboard/dashboards/project/volumes/volumes/tests.py
@@ -963,7 +963,7 @@ def test_detail_view(self):
                       args=[volume.id])
         res = self.client.get(url)
 
-        self.assertContains(res, "<h2>Volume Details: Volume name</h2>",
+        self.assertContains(res, "<h1>Volume Details: Volume name</h1>",
                             1, 200)
         self.assertContains(res, "<dd>Volume name</dd>", 1, 200)
         self.assertContains(res, "<dd>%s</dd>" % volume.id, 1, 200)

diff --git a/openstack_dashboard/static/dashboard/scss/horizon.scss b/openstack_dashboard/static/dashboard/scss/horizon.scss
@@ -176,12 +176,12 @@ dt {
 
 .page-header {
   margin: 0 0 5px 0;
-  padding: 0 0 5px 0;
-  border-bottom: 2px solid $headings-color;
+  padding: 10px 0 5px 0;
+  border-bottom: 0;
   font-family: anivers;
   height: auto;
   width: 100%;
-  h2 {
+  h1 {
     margin: 0;
   }
 }