Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Escape angularjs templating in unsafe HTML
This code extends the unsafe (typically user-supplied) HTML escape built into Django to also escape angularjs templating markers. Safe HTML will be unaffected. Closes-bug: 1567673 Change-Id: I0cbebfd0f814bdf1bf8c06833abf33cc2d4748e7 (cherry picked from commit 4bc01cedf39cdeff2553d01cdace707a1ecf6620)
- Loading branch information
1 parent
68c0fd0
commit d585e5e
Showing
3 changed files
with
40 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Copyright 2016, Rackspace, US, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import django.utils.html | ||
|
||
|
||
def escape(text, existing=django.utils.html.escape): | ||
# Replace our angular markup string with a different string | ||
# (which just happens to be the Django comment string) | ||
# this prevents user-supplied data from being intepreted in | ||
# our pages by angularjs, thus preventing it from being used | ||
# for XSS attacks. Note that we use {$ $} instead of the | ||
# standard {{ }} - this is configured in horizon.framework | ||
# angularjs module through $interpolateProvider | ||
return existing(text).replace('{$', '{%').replace('$}', '%}') | ||
|
||
|
||
# this will be invoked as early as possible in settings.py | ||
def monkeypatch_escape(): | ||
django.utils.html.escape = escape |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters