Skip to content

Commit

Permalink
Merge "Make no response notification(msg) level to INFO"
Browse files Browse the repository at this point in the history
  • Loading branch information
Jenkins authored and openstack-gerrit committed Mar 31, 2016
2 parents 8fcfa80 + d3dd5e0 commit e1f07e2
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 16 deletions.
2 changes: 1 addition & 1 deletion openstack_dashboard/dashboards/admin/instances/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def handle(self, request, data):
disk_over_commit=disk_over_commit)
msg = _('The instance is preparing the live migration '
'to host "%s".') % data['host']
messages.success(request, msg)
messages.info(request, msg)
return True
except Exception:
msg = _('Failed to live migrate instance to '
Expand Down
6 changes: 3 additions & 3 deletions openstack_dashboard/dashboards/project/images/images/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ def handle(self, request, data):

try:
image = api.glance.image_create(request, **meta)
messages.success(request,
_('Your image %s has been queued for creation.') %
meta['name'])
messages.info(request,
_('Your image %s has been queued for creation.') %
meta['name'])
return image
except Exception as e:
msg = _('Unable to create new image')
Expand Down
2 changes: 1 addition & 1 deletion openstack_dashboard/dashboards/project/instances/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def handle(self, request, data):
try:
api.nova.server_rebuild(request, instance, image, password,
disk_config)
messages.success(request, _('Rebuilding instance %s.') % instance)
messages.info(request, _('Rebuilding instance %s.') % instance)
except Exception:
redirect = reverse('horizon:project:instances:index')
exceptions.handle(request, _("Unable to rebuild instance."),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,8 @@ class LaunchInstance(workflows.Workflow):
slug = "launch_instance"
name = _("Launch Instance")
finalize_button_name = _("Launch")
success_message = _('Launched %(count)s named "%(name)s".')
success_message = _('Request for launching %(count)s named "%(name)s" '
'has been submitted.')
failure_message = _('Unable to launch %(count)s named "%(name)s".')
success_url = "horizon:project:instances:index"
multipart = True
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ class ResizeInstance(workflows.Workflow):
slug = "resize_instance"
name = _("Resize Instance")
finalize_button_name = _("Resize")
success_message = _('Scheduled resize of instance "%s".')
success_message = _('Request for resizing of instance "%s" '
'has been submitted.')
failure_message = _('Unable to resize instance "%s".')
success_url = "horizon:project:instances:index"
default_steps = (SetFlavorChoice, create_instance.SetAdvanced)
Expand Down
4 changes: 2 additions & 2 deletions openstack_dashboard/dashboards/project/stacks/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def handle(self, request, data):

try:
api.heat.stack_create(self.request, **fields)
messages.success(request, _("Stack creation started."))
messages.info(request, _("Stack creation started."))
return True
except Exception:
exceptions.handle(request)
Expand Down Expand Up @@ -430,7 +430,7 @@ def handle(self, request, data):

try:
api.heat.stack_update(self.request, stack_id=stack_id, **fields)
messages.success(request, _("Stack update started."))
messages.info(request, _("Stack update started."))
return True
except Exception:
exceptions.handle(request)
Expand Down
11 changes: 6 additions & 5 deletions openstack_dashboard/dashboards/project/volumes/backups/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def handle(self, request, data):
data['description'])

message = _('Creating volume backup "%s"') % data['name']
messages.success(request, message)
messages.info(request, message)
return backup

except Exception:
Expand Down Expand Up @@ -98,10 +98,11 @@ def handle(self, request, data):
# Needed for cases when a new volume is created.
volume_id = restore.volume_id

message = _('Successfully restored backup %(backup_name)s '
'to volume with id: %(volume_id)s')
messages.success(request, message % {'backup_name': backup_name,
'volume_id': volume_id})
message = _('Request for restoring backup %(backup_name)s '
'to volume with id: %(volume_id)s '
'has been submitted.')
messages.info(request, message % {'backup_name': backup_name,
'volume_id': volume_id})
return restore
except Exception:
msg = _('Unable to restore backup.')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,5 @@ def test_restore_backup(self):
res = self.client.post(url, formData)

self.assertNoFormErrors(res)
self.assertMessageCount(success=1)
self.assertMessageCount(info=1)
self.assertRedirectsNoFollow(res, INDEX_URL)
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def image_create(self, local_file=None):
image_file=local_file)
else:
images_page.create_image(IMAGE_NAME)
self.assertTrue(images_page.find_message_and_dismiss(messages.SUCCESS))
self.assertTrue(images_page.find_message_and_dismiss(messages.INFO))
self.assertFalse(images_page.find_message_and_dismiss(messages.ERROR))
self.assertTrue(images_page.is_image_present(IMAGE_NAME))
self.assertTrue(images_page.is_image_active(IMAGE_NAME))
Expand Down

0 comments on commit e1f07e2

Please sign in to comment.