Skip to content

Commit

Permalink
Revert "CI: Disable bare metal testing on RL9/c9s"
Browse files Browse the repository at this point in the history
This requires disabling libvirt_vm_trust_guest_rx_filters, which when
enabled triggers the following errors when booting baremetal instances
with Tenks on Libvirt 9 (and most likely since 8.9.0):

    Cannot set interface flags on 'macvtap1': Value too large for defined data type

This is apparently triggered by a Libvirt commit refreshing rx-filters
more often [1].

As explained in I71a2051d8acd63379bd70bc1287a059d4a7f6387, this setting
was added to allow traffic destined for other MAC addresses to reach VMs
when using a macvtap interface.

This will prevent multicast from working, but we don't need it for
baremetal tests in CI.

This setting will be enabled again once the issue is resolved in either
Libvirt or Tenks.

This reverts commit 21c68bb.

Also increase timeout of upgrade jobs which is too short now due to the
added delay added by bare metal testing.

[1] https://gitlab.com/libvirt/libvirt/-/commit/060d4c83ef436cf56abfad51a4d64c39448e199d

Change-Id: I2cfd2667abb1ae8988b7a7fd9761b75c20a0eaa4
  • Loading branch information
priteau committed Oct 9, 2023
1 parent 80d49f7 commit 990370a
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
6 changes: 6 additions & 0 deletions dev/tenks-deploy-config-compute-libvirt-on-host.yml
Expand Up @@ -54,3 +54,9 @@ libvirt_vm_emulator: "{% if ansible_facts.os_family == 'RedHat' %}/usr/libexec/q
# Specify a log path in the kolla_logs Docker volume. It is accessible on the
# host at the same path.
libvirt_vm_default_console_log_dir: "/var/log/kolla/tenks"

# NOTE(priteau): Disable libvirt_vm_trust_guest_rx_filters, which when enabled
# triggers the following errors when booting baremetal instances with Tenks on
# Libvirt 9: Cannot set interface flags on 'macvtap1': Value too large for
# defined data type
libvirt_vm_trust_guest_rx_filters: false
6 changes: 6 additions & 0 deletions dev/tenks-deploy-config-compute.yml
Expand Up @@ -55,3 +55,9 @@ libvirt_vm_default_console_log_dir: "/var/log/kolla/tenks"
# Console logs are owned by the ID of the Nova user in the nova_libvirt
# container.
libvirt_vm_log_owner: 42436

# NOTE(priteau): Disable libvirt_vm_trust_guest_rx_filters, which when enabled
# triggers the following errors when booting baremetal instances with Tenks on
# Libvirt 9: Cannot set interface flags on 'macvtap1': Value too large for
# defined data type
libvirt_vm_trust_guest_rx_filters: false
2 changes: 0 additions & 2 deletions playbooks/kayobe-overcloud-base/run.yml
Expand Up @@ -41,5 +41,3 @@
cmd: dev/overcloud-test-baremetal.sh &> {{ logs_dir }}/ansible/overcloud-test-baremetal
chdir: "{{ kayobe_src_dir }}"
executable: /bin/bash
# FIXME(priteau): Bare metal testing fails on RL9/c9s with Libvirt 9.0.0
when: ansible_facts.os_family == 'Debian'
4 changes: 0 additions & 4 deletions playbooks/kayobe-overcloud-upgrade-base/run.yml
Expand Up @@ -81,8 +81,6 @@
cmd: dev/overcloud-test-baremetal.sh &> {{ logs_dir }}/ansible/overcloud-test-bm-pre-upgrade
chdir: "{{ previous_kayobe_src_dir }}"
executable: /bin/bash
# FIXME(priteau): Bare metal testing fails on RL9/c9s with Libvirt 9.0.0
when: ansible_facts.os_family == 'Debian'

# Upgrade Kayobe, and use it to perform an upgrade of the control plane.

Expand Down Expand Up @@ -110,8 +108,6 @@
cmd: dev/overcloud-test-baremetal.sh &> {{ logs_dir }}/ansible/overcloud-test-bm-post-upgrade
chdir: "{{ kayobe_src_dir }}"
executable: /bin/bash
# FIXME(priteau): Bare metal testing fails on RL9/c9s with Libvirt 9.0.0
when: ansible_facts.os_family == 'Debian'

environment:
KAYOBE_CONFIG_SOURCE_PATH: "{{ kayobe_config_src_dir }}"
Expand Down
2 changes: 1 addition & 1 deletion zuul.d/jobs.yaml
Expand Up @@ -162,7 +162,7 @@
OpenStack release, and upgrades it to the current release.
pre-run: playbooks/kayobe-overcloud-upgrade-base/pre.yml
run: playbooks/kayobe-overcloud-upgrade-base/run.yml
timeout: 9000
timeout: 10800

- job:
name: kayobe-overcloud-upgrade-rocky9
Expand Down

0 comments on commit 990370a

Please sign in to comment.