Merge "usage: Fix time filtering"

openstack · Jan 24, 2012 · 57cf831 · 57cf831
2 parents 06ba4a2 + 4110add
commit 57cf831
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/nova/db/sqlalchemy/api.py b/nova/db/sqlalchemy/api.py
@@ -1581,36 +1581,36 @@ def _regexp_filter_by_column(instance, filter_name, filter_re):
 
 @require_context
 def instance_get_active_by_window(context, begin, end=None, project_id=None):
-    """Return instances that were continuously active over window."""
+    """Return instances that were active during window."""
     session = get_session()
-    query = session.query(models.Instance).\
-                    filter(models.Instance.launched_at < begin)
+    query = session.query(models.Instance)
+
+    query = query.filter(or_(models.Instance.terminated_at == None,
+                             models.Instance.terminated_at > begin))
     if end:
-        query = query.filter(or_(models.Instance.terminated_at == None,
-                                 models.Instance.terminated_at > end))
-    else:
-        query = query.filter(models.Instance.terminated_at == None)
+        query = query.filter(models.Instance.launched_at < end)
     if project_id:
         query = query.filter_by(project_id=project_id)
+
     return query.all()
 
 
 @require_admin_context
 def instance_get_active_by_window_joined(context, begin, end=None,
                                          project_id=None):
-    """Return instances and joins that were continuously active over window."""
+    """Return instances and joins that were active during window."""
     session = get_session()
-    query = session.query(models.Instance).\
-                    options(joinedload('security_groups')).\
-                    options(joinedload('instance_type')).\
-                    filter(models.Instance.launched_at < begin)
+    query = session.query(models.Instance)
+
+    query = query.options(joinedload('security_groups')).\
+                  options(joinedload('instance_type')).\
+                  filter(or_(models.Instance.terminated_at == None,
+                             models.Instance.terminated_at > begin))
     if end:
-        query = query.filter(or_(models.Instance.terminated_at == None,
-                                 models.Instance.terminated_at > end))
-    else:
-        query = query.filter(models.Instance.terminated_at == None)
+        query = query.filter(models.Instance.launched_at < end)
     if project_id:
         query = query.filter_by(project_id=project_id)
+
     return query.all()