Skip to content

Commit

Permalink
Start using hacking 0.6
Browse files Browse the repository at this point in the history
So we can start using new hacking 0.6 checks.

Since hacking 0.6 pins pep8, pyflakes and flake8 they can be removed
from test-requires. For any unfixed checks list them in tox.ini

Fix a H103, 'Header does not match Apache 2.0 License notice' that
leaked in

Change-Id: I652fe3270f1c37afdd386bfae7c4b27b6abcfa06
  • Loading branch information
jogo committed Jul 25, 2013
1 parent 19dc70f commit dea5ce7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion nova/api/openstack/compute/plugins/v3/migrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License
# under the License.

from nova.api.openstack import extensions
from nova.api.openstack import wsgi
Expand Down
7 changes: 1 addition & 6 deletions test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
# Install bounded pep8/pyflakes first, then let flake8 install
pep8==1.4.5
pyflakes==0.7.2
flake8==2.0
hacking>=0.5.3,<0.6

hacking>=0.5.6,<0.7
coverage>=3.6
discover
feedparser
Expand Down
8 changes: 7 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ commands =
commands = {posargs}

[flake8]
ignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H302,H303,H404,F403,F811,F841,N309
# TODO Hacking 0.6 checks to fix
# H102 Apache 2.0 license header not found
# H232 Python 3.x incompatible octal 1 should be written as 0o1
# H233 Python 3.x incompatible use of print operator
# H501 Do not use locals() for string formatting

ignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H102,H232,H233,H302,H303,H404,F403,H501,F811,F841,N309
builtins = _
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,*plugins/xenserver*,tools

Expand Down

0 comments on commit dea5ce7

Please sign in to comment.