Skip to content

Commit

Permalink
Merge "replace assertNotEquals with assertNotEqual"
Browse files Browse the repository at this point in the history
  • Loading branch information
Jenkins authored and openstack-gerrit committed Nov 14, 2013
2 parents 0535514 + bbe3b2c commit e5ca566
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_create_security_group_default_rule_with_no_cidr(self):
res_dict = self.controller.create(req,
{'security_group_default_rule': sgr})
security_group_default_rule = res_dict['security_group_default_rule']
self.assertNotEquals(security_group_default_rule['id'], 0)
self.assertNotEqual(security_group_default_rule['id'], 0)
self.assertEqual(security_group_default_rule['ip_range']['cidr'],
'0.0.0.0/0')

Expand Down Expand Up @@ -145,7 +145,7 @@ def test_create_security_group_default_rule_with_blank_cidr(self):
res_dict = self.controller.create(req,
{'security_group_default_rule': sgr})
security_group_default_rule = res_dict['security_group_default_rule']
self.assertNotEquals(security_group_default_rule['id'], 0)
self.assertNotEqual(security_group_default_rule['id'], 0)
self.assertEqual(security_group_default_rule['ip_range']['cidr'],
'0.0.0.0/0')

Expand Down
16 changes: 8 additions & 8 deletions nova/tests/api/openstack/compute/contrib/test_security_groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ def test_create_by_cidr(self):
req = fakes.HTTPRequest.blank('/v2/fake/os-security-group-rules')
res_dict = self.controller.create(req, {'security_group_rule': rule})
security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.sg2['id'])
self.assertEqual(security_group_rule['ip_range']['cidr'],
Expand All @@ -760,7 +760,7 @@ def test_create_by_group_id(self):
res_dict = self.controller.create(req, {'security_group_rule': rule})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.sg2['id'])

Expand All @@ -778,7 +778,7 @@ def test_create_by_same_group_id(self):
res_dict = self.controller.create(req, {'security_group_rule': rule2})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.sg2['id'])
self.assertEqual(security_group_rule['from_port'], 81)
Expand Down Expand Up @@ -990,7 +990,7 @@ def test_create_with_no_cidr_group(self):
res_dict = self.controller.create(req, {'security_group_rule': rule})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.parent_security_group['id'])
self.assertEqual(security_group_rule['ip_range']['cidr'],
Expand Down Expand Up @@ -1026,7 +1026,7 @@ def test_create_with_same_group_parent_id_and_group_id(self):
req = fakes.HTTPRequest.blank('/v2/fake/os-security-group-rules')
res_dict = self.controller.create(req, {'security_group_rule': rule})
security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.sg1['id'])
self.assertEqual(security_group_rule['group']['name'],
Expand Down Expand Up @@ -1160,7 +1160,7 @@ def test_create_rule_cidr_allow_all(self):
res_dict = self.controller.create(req, {'security_group_rule': rule})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.parent_security_group['id'])
self.assertEqual(security_group_rule['ip_range']['cidr'],
Expand All @@ -1174,7 +1174,7 @@ def test_create_rule_cidr_ipv6_allow_all(self):
res_dict = self.controller.create(req, {'security_group_rule': rule})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.parent_security_group['id'])
self.assertEqual(security_group_rule['ip_range']['cidr'],
Expand All @@ -1188,7 +1188,7 @@ def test_create_rule_cidr_allow_some(self):
res_dict = self.controller.create(req, {'security_group_rule': rule})

security_group_rule = res_dict['security_group_rule']
self.assertNotEquals(security_group_rule['id'], 0)
self.assertNotEqual(security_group_rule['id'], 0)
self.assertEqual(security_group_rule['parent_group_id'],
self.parent_security_group['id'])
self.assertEqual(security_group_rule['ip_range']['cidr'],
Expand Down
2 changes: 1 addition & 1 deletion nova/tests/test_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,5 +242,5 @@ def setUp(self):

def test_launch_app(self):
service.serve(self.service)
self.assertNotEquals(0, self.service.port)
self.assertNotEqual(0, self.service.port)
service._launcher.stop()
2 changes: 1 addition & 1 deletion nova/tests/test_wsgi.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def test_app(env, start_response):
fake_server = nova.wsgi.Server("fake", test_app,
host="127.0.0.1", port=0)
fake_server.start()
self.assertNotEquals(0, fake_server.port)
self.assertNotEqual(0, fake_server.port)

cli = eventlet.connect(("localhost", fake_ssl_server.port))
cli = eventlet.wrap_ssl(cli,
Expand Down
2 changes: 1 addition & 1 deletion nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_get_datastore_ref_and_name_with_list(self):
fake_objects.add_object(fake.Datastore("openstack-ds2"))
result = vm_util.get_datastore_ref_and_name(
fake_session(fake_objects), None, None, datastore_valid_regex)
self.assertNotEquals("openstack-ds1", result[1])
self.assertNotEqual("openstack-ds1", result[1])

def test_get_datastore_ref_and_name_with_regex_error(self):
# Test with a regex that has no match
Expand Down
6 changes: 3 additions & 3 deletions smoketests/test_sysadmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,9 @@ def test_005_volume_is_correct_size(self):
conn.close()
# NOTE(vish): 1G bytes / 512 bytes per block
expected_size = 1024 * 1024 * 1024 / 512
self.assertEquals('%s' % (expected_size,), out,
'Volume is not the right size: %s %s. Expected: %s' %
(out, stderr.read(), expected_size))
self.assertEqual('%s' % (expected_size,), out,
'Volume is not the right size: %s %s. Expected: %s' %
(out, stderr.read(), expected_size))

def test_006_me_can_umount_volume(self):
ip = self.data['instance'].private_ip_address
Expand Down

0 comments on commit e5ca566

Please sign in to comment.