Deprecate API extensions policies

Nova API extension concept is removed in Pike. These extensions have their own policies enforcement which are not needed any more. All the below policies which were added mainly for extensions are deprecated for removal- - 'os_compute_api:os-config-drive' - 'os_compute_api:os-extended-availability-zone' - 'os_compute_api:os-extended-status' - 'os_compute_api:os-extended-volumes' - 'os_compute_api:os-keypairs' - 'os_compute_api:os-server-usage' - 'os_compute_api:os-security-groups' (only from /servers APIs) - 'os_compute_api:os-flavor-rxtx' - 'os_compute_api:os-flavor-access' (only from /flavors APIs) - 'os_compute_api:image-size' Implement blueprint api-extensions-policy-removal Depends-On: I6aed4909b0e7efe9c95d1f7398db613eca05e5ce Change-Id: Ie05f4e84519f8a00ffb66ea5ee920d5c7722a66b
openstack · Dec 7, 2017 · f2d18c2 · f2d18c2
1 parent 9f46043
commit f2d18c2
Show file tree

Hide file tree

Showing 11 changed files with 125 additions and 10 deletions.
diff --git a/nova/policies/config_drive.py b/nova/policies/config_drive.py
@@ -35,7 +35,15 @@
                 'method': 'GET',
                 'path': '/servers/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-config-drive" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/extended_availability_zone.py b/nova/policies/extended_availability_zone.py
@@ -35,7 +35,15 @@
                 'method': 'GET',
                 'path': '/servers/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-extended-availability-zone"'
+            ' policy which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/extended_status.py b/nova/policies/extended_status.py
@@ -42,7 +42,15 @@
                 'method': 'GET',
                 'path': '/servers/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-extended-status" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/extended_volumes.py b/nova/policies/extended_volumes.py
@@ -36,7 +36,15 @@
                 'method': 'GET',
                 'path': '/servers/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-extended-volumes" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/flavor_access.py b/nova/policies/flavor_access.py
@@ -75,7 +75,20 @@
                 'method': 'PUT',
                 'path': '/flavors/{flavor_id}'
             },
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-flavor-access" policy '
+            'for POST, PUT, GET /flavors which was added for extensions is '
+            'not needed any more. NOTE: This policy is deprecated only for '
+            'POST /flavors, PUT /flavors, GET /flavors/{flavor_id} & '
+            'GET /flavors/detail. This policy for other API operations is '
+            'still valid and not deprecated'
+
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/flavor_rxtx.py b/nova/policies/flavor_rxtx.py
@@ -44,7 +44,15 @@
                 'method': 'PUT',
                 'path': '/flavors/{flavor_id}'
             },
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-flavor-rxtx" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/image_size.py b/nova/policies/image_size.py
@@ -35,7 +35,15 @@
                 'method': 'GET',
                 'path': '/images/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:image-size" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/keypairs.py b/nova/policies/keypairs.py
@@ -76,7 +76,15 @@
                 'path': '/servers/detail',
                 'method': 'GET'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-keypairs" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/security_groups.py b/nova/policies/security_groups.py
@@ -81,7 +81,19 @@
             'method': 'GET',
             'path': '/servers/detail'
         }
-    ]),
+    ],
+    deprecated_for_removal=True,
+    deprecated_reason=(
+        'Nova API extension concept has been removed in Pike. Those '
+        'extensions have their own policies enforcement. As there is '
+        'no extensions now, "os_compute_api:os-security-groups" policy '
+        'for POST, GET /servers which was added for extensions is not '
+        'needed any more. NOTE: This policy is deprecated only for '
+        'POST /servers, GET /servers/{server_id} & GET /servers/detail. '
+        'This policy for other API operations is still valid and not '
+        'deprecated'
+    ),
+    deprecated_since='17.0.0'),
 ]
 
 

diff --git a/nova/policies/server_usage.py b/nova/policies/server_usage.py
@@ -42,7 +42,15 @@
                 'method': 'GET',
                 'path': '/servers/detail'
             }
-        ]),
+        ],
+        deprecated_for_removal=True,
+        deprecated_reason=(
+            'Nova API extension concept has been removed in Pike. Those '
+            'extensions have their own policies enforcement. As there is '
+            'no extensions now, "os_compute_api:os-server-usage" policy '
+            'which was added for extensions is not needed any more'
+        ),
+        deprecated_since='17.0.0'),
 ]
 
 

diff --git a/releasenotes/notes/deprecate-api-extensions-policies-5613bc4eea59709d.yaml b/releasenotes/notes/deprecate-api-extensions-policies-5613bc4eea59709d.yaml
@@ -0,0 +1,26 @@
+---
+deprecations:
+  - |
+    Nova API extension concept is removed in Pike. These extensions
+    have their own policies enforcement which are not needed any more.
+    All the below policies which were added mainly for extensions are
+    deprecated for removal-
+
+    - Show & List detail server
+
+        - 'os_compute_api:os-config-drive'
+        - 'os_compute_api:os-extended-availability-zone'
+        - 'os_compute_api:os-extended-status'
+        - 'os_compute_api:os-extended-volumes'
+        - 'os_compute_api:os-keypairs'
+        - 'os_compute_api:os-server-usage'
+        - 'os_compute_api:os-security-groups' (only from /servers APIs)
+
+    - Create, Update, Show & List detail flavor
+
+        - 'os_compute_api:os-flavor-rxtx'
+        - 'os_compute_api:os-flavor-access' (only from /flavors APIs)
+
+    - Show & List detail image
+
+        - 'os_compute_api:image-size'