Skip to content

Commit

Permalink
Correct failure when stopping cluster state is ignored
Browse files Browse the repository at this point in the history
If the user passes in the `galera_ignore_cluster_state=true` flag, like
in the case of a node addition or a rolling replacement of nodes,
this role will fail to execute on all new nodes due to the existance of
a functioning cluster galera cluster. The first task in the pre-upgrade
steps attempts to stop the mysql service prior to running anything else.
This change makes it so the mysql service will not fail to stop on this
pre-upgrade task when the `galera_ignore_cluster_state=true` is passed
through.

Change-Id: Id9c4f11b3536e7f9d510f5ef8e6d82a82a96adac
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
  • Loading branch information
cloudnull committed Oct 2, 2018
1 parent 10652de commit 068bb72
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tasks/galera_upgrade_pre.yml
Expand Up @@ -14,9 +14,10 @@
# limitations under the License.

- name: Stop MariaDB
service:
systemd:
name: mysql
state: stopped
failed_when: "{{ (not galera_ignore_cluster_state | bool) | default(omit, false) }}"
register: galera_restart_fall_back
until: galera_restart_fall_back is success
retries: 3
Expand Down

0 comments on commit 068bb72

Please sign in to comment.