Skip to content

Commit

Permalink
Optimise apt cache update task
Browse files Browse the repository at this point in the history
The update of the apt cache and the package installation
can all be handled in a single task by providing the
package action plugin with the right parameters. This
removes an extra task to optimise execution.

The minimum Ansible version is raised to 2.2 due to a
known bug [1] in Ansible's apt module which does not
update the cache properly if the cache update and the
install are combined in a single task.

[1] ansible/ansible-modules-core#1497

Change-Id: I69970a3a76e6ac56095d0077c31f811d717d9216
(cherry picked from commit 9d43b6f)
  • Loading branch information
Jesse Pretorius committed Apr 26, 2017
1 parent 4ff9ef0 commit 4b5d66c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion meta/main.yml
Expand Up @@ -18,7 +18,7 @@ galaxy_info:
description: Installation and setup of neutron
company: Rackspace
license: Apache2
min_ansible_version: 2.0
min_ansible_version: 2.2
platforms:
- name: Ubuntu
versions:
Expand Down
9 changes: 2 additions & 7 deletions tasks/neutron_install.yml
Expand Up @@ -13,17 +13,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.

- name: Ensure apt cache is up to date
apt:
update_cache: yes
cache_valid_time: "{{ cache_timeout }}"
when:
- ansible_pkg_mgr == 'apt'

- name: Install neutron role packages
package:
name: "{{ item }}"
state: "{{ neutron_package_state }}"
update_cache: "{{ (ansible_pkg_mgr == 'apt') | ternary('yes', omit) }}"
cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
with_items:
- "{{ neutron_packages_list | selectattr('enabled') | sum(attribute='packages', start=[]) }}"
when:
Expand Down

0 comments on commit 4b5d66c

Please sign in to comment.