Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
processutils: ensure on_completion callback is always called
If the subprocess.Popen.communicate method raises an exception, the on_completion callback is never invoked. If a caller is trying to use on_execute + on_completion to track lifecycle of a process this creates a problem, as they cannot reliably detect completion. Conflicts: oslo_concurrency/processutils.py oslo_concurrency/tests/unit/test_processutils.py Change-Id: I22b2d7bde8797276f7670bc289d915dab5122481 Closes-bug: #1470868 (cherry picked from commit ab78480)
- Loading branch information
1 parent
a258e67
commit 2855b6e
Showing
2 changed files
with
29 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters