Skip to content

Commit

Permalink
Don't use ConfigFilter for lockutils
Browse files Browse the repository at this point in the history
In Neutron, we usually specify lock_path as:

lock_path = $state_path/lock

It turned out that ConfigFilter does not work correctly with
substitution feature, so its usage blocks Neutron adoption of the
library.

The issue is also not specific to Neutron: any deployer should be able
to use substitutions ($smth) in their configuration files without
determining whether those configuration options he's interested in are
defined as ConfigOpts or ConfigFilter.

So the best short term approach to push forward the adoption of the
library is to refrain from using ConfigFilter at least until there is
consensus on how to support substitution feature with the class.

Once oslo.config sorts the issue out, we may get back to using
ConfigFilter for lockutils.

Change-Id: I7b0b5c840381b2d9afc00ff116fee1d970743183
Closes-Bug: #1399897
  • Loading branch information
booxter committed Dec 15, 2014
1 parent e5a357d commit 9dd6d21
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions oslo_concurrency/lockutils.py
Expand Up @@ -27,7 +27,6 @@
import weakref

from oslo.config import cfg
from oslo.config import cfgfilter
import retrying
import six

Expand All @@ -53,7 +52,7 @@
]


CONF = cfgfilter.ConfigFilter(cfg.CONF)
CONF = cfg.CONF
CONF.register_opts(_opts, group='oslo_concurrency')


Expand Down

0 comments on commit 9dd6d21

Please sign in to comment.