Skip to content

Commit

Permalink
Don't test with setuptools local distutils.
Browse files Browse the repository at this point in the history
We noticed some aberrations in log level/threshold handling as of
Setuptools 60.0.0, and the only substantive change for that release[1]
toggles the default selection for its internal ("local") distutils
replacement vs the "stdlib" one. For now, toggle the
SETUPTOOLS_USE_DISTUTILS envvar in our testing back to the old
value. This should be revisited once logging is handled better in
Setuptools.

[1] pypa/setuptools#3038

Change-Id: I2eacb9756d9eb9c5d606599f16cdb412007f5854
  • Loading branch information
damani42 committed Jan 21, 2022
1 parent f4cbe4c commit 8d44224
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ ignore_basepython_conflict = true

[testenv]
basepython = python3
# TODO(damani): Drop distutils override once logging improves in setuptools
# https://github.com/pypa/setuptools/issues/3038
setenv =
SETUPTOOLS_USE_DISTUTILS=stdlib
deps =
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/test-requirements.txt
Expand All @@ -30,7 +34,10 @@ commands =
sphinx-build -W --keep-going -b html doc/source doc/build/html

[testenv:cover]
# TODO(damani): Drop distutils override once logging improves in setuptools
# https://github.com/pypa/setuptools/issues/3038
setenv =
SETUPTOOLS_USE_DISTUTILS=stdlib
PYTHON=coverage run --source oslo_context --parallel-mode
commands =
stestr run {posargs}
Expand Down

0 comments on commit 8d44224

Please sign in to comment.