Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Accept 'valid_interfaces' in client setup
The consumer of ironicclient may be deriving their get_client kwargs from config inherited from ksa, where the 'interface' option has been deprecated in favor of 'valid_interfaces'. To accomodate this, we accept 'valid_interfaces' as a kwarg, giving it precedence over 'interface'. However, we still accept 'interface', as the consumer may be deriving kwargs from a non-conf source (such as an already-created ksa Adapter where 'valid_interfaces' has already been translated to 'interfaces'. Co-Authored-By: guang-yee <guang.yee@suse.com> Change-Id: I3b6fa53005f143d34f03bb1ed71c0aa04b7fce7b
- Loading branch information
Showing
3 changed files
with
46 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
releasenotes/notes/accept-valid_interfaces-3b8f5e3e362e04cd.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
features: | ||
- | | ||
The consumer of ironicclient may be deriving their ``get_client`` kwargs | ||
from config inherited from ksa, where the ``interface`` option has been | ||
deprecated in favor of ``valid_interfaces``. To accomodate this, we now | ||
accept ``valid_interfaces`` as a kwarg, giving it precedence over | ||
``interface``. However, we still accept ``interface``, as the consumer may | ||
be deriving kwargs from a non-conf source (such as an already-created ksa | ||
Adapter where ``valid_interfaces`` has already been translated to | ||
``interfaces``. |