Skip to content

Commit

Permalink
Merge "Adding duration header to rally verify list query"
Browse files Browse the repository at this point in the history
  • Loading branch information
Jenkins authored and openstack-gerrit committed Jan 17, 2015
2 parents 503b61f + 8ea4e71 commit b5da99a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
6 changes: 5 additions & 1 deletion rally/cmd/commands/verify.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ def list(self):
"""Display all verifications table, started and finished."""

fields = ["UUID", "Deployment UUID", "Set name", "Tests", "Failures",
"Created at", "Status"]
"Created at", "Duration", "Status"]
verifications = db.verification_list()

for el in verifications:
el["duration"] = el["updated_at"] - el["created_at"]

if verifications:
common_cliutils.print_list(verifications, fields,
sortby_index=fields.index("Created at"))
Expand Down
11 changes: 9 additions & 2 deletions tests/unit/cmd/commands/test_verify.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.

import datetime as date
import tempfile

import mock
Expand Down Expand Up @@ -96,10 +97,16 @@ def test_start_with_wrong_set_name(self, mock_verify):
@mock.patch("rally.db.verification_list")
def test_list(self, mock_db_verification_list, mock_print_list):
fields = ["UUID", "Deployment UUID", "Set name", "Tests", "Failures",
"Created at", "Status"]
verifications = {"dummy": []}
"Created at", "Duration", "Status"]
verifications = [{"created_at": date.datetime.now(),
"updated_at": date.datetime.now()}]
mock_db_verification_list.return_value = verifications
self.verify.list()

for row in verifications:
self.assertEqual(row["updated_at"] - row["created_at"],
row["duration"])

mock_db_verification_list.assert_called_once_with()
mock_print_list.assert_called_once_with(verifications, fields,
sortby_index=fields.index(
Expand Down

0 comments on commit b5da99a

Please sign in to comment.